Closed Bug 1633519 Opened 4 years ago Closed 4 years ago

Raise browsertime error when it fails instead of generic ones

Categories

(Testing :: Performance, task, P1)

Version 3
task

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: sparky, Assigned: sparky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently, when browsertime fails, we fail with very generic messages like "no results found". Instead we should be pulling them from the browsertime.json file.

This patch adds a line handler to the mozprocess object responsible for running browsertime.

The line handler strips away some unnecessary information the log, and then outputs it using Raptor's log handler (level determined by browsertime log message). If a line that is prefixed with error we immediately raise an exception to kill the process handler, and then raise the failure in Raptor to prevent results processing.

Pushed by gmierz2@outlook.com: https://hg.mozilla.org/integration/autoland/rev/ace557885b11 Reformat browsertime output and catch the errors. r=tarek
Blocks: 1635183
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: