Remove message recommending closing the other browser (due to Chrome locking)
Categories
(Firefox :: Migration, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox109 | --- | fixed |
People
(Reporter: Mardak, Assigned: brianpt1106)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1305770 added support for importing when Chrome is running. Perhaps the message from bug 706005 is no longer necessary?
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Comment 1•2 years ago
|
||
Hey Brian, got another cleanup bug for you. Basically, we show a message when importing from Chrome/Chromium-based browsers that we don't need to anymore.
That message is this one: https://searchfox.org/mozilla-central/rev/8a2d8d26e25ef70c98c6036612aad534b76b9815/browser/locales/en-US/browser/migration.ftl#88
Which means we can get rid of this: https://searchfox.org/mozilla-central/source/browser/components/migration/content/migration.xhtml#71
and the code that supports it: https://searchfox.org/mozilla-central/rev/8a2d8d26e25ef70c98c6036612aad534b76b9815/browser/components/migration/content/migration.js#197-209,253
I also believe this means we can remove the sourceLocked getter on our migrators.
A lot of this was added back in bug 706005, which was a way back, but that can be used as a blueprint on what you can remove.
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dcf03592c594 Remove message recommending closing the other browser (due to Chrome locking). r=mconley
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Description
•