Closed
Bug 1633953
Opened 5 years ago
Closed 5 years ago
SWGL accidentally terminates polygons at duplicate vertices
Categories
(Core :: Graphics: WebRender, defect, P3)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
WR occasionally specifies triangles as quads with duplicate vertices (i.e. ABBC), so we need to check for those in the termination condition for quad rendering. This can notably cause wrench reftest split/same-plane to fail.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D72989
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04bbc283b6e1
check for duplicate vertices in SWGL quad rendering. r=jimb
https://hg.mozilla.org/integration/autoland/rev/e37efe5414d6
refactor draw_quad_spans edge stepping to make it easier to read. r=jimb
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/04bbc283b6e1
https://hg.mozilla.org/mozilla-central/rev/e37efe5414d6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•