[lwtheme with image, light text] Text in gCal alert has drop shadow
Categories
(Toolkit Graveyard :: Notifications and Alerts, defect)
Tracking
(firefox-esr68 unaffected, firefox75 unaffected, firefox76 unaffected, firefox77+ fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox75 | --- | unaffected |
| firefox76 | --- | unaffected |
| firefox77 | + | fixed |
People
(Reporter: mconca, Assigned: Gijs)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files, 1 obsolete file)
fuzzy.jpg
On the latest NIghtly (77.0a1 2020-04-29) all of my Google Calendar alerts have fuzzy text, it looks like a drop shadow. This is reproducible in the console by alert("Text"). See attached example.
|
||
Updated•4 years ago
|
|
|
||
Comment 1•4 years ago
|
||
Thanks for filing!
Couldn't reproduce this yet. Tested on Linux and Windows 10 with latest Nightly (clean profile).
|
Assignee | |
Comment 2•4 years ago
|
||
I can't reproduce by just firing an alert() on current nightly on a bmo page on Windows 10... so unsure what's going on.
Mike, if you inspect the alert text with the browser toolbox (ctrl-alt-shift-i), does the CSS pane's computed style tab list a text-shadow rule? If so, can you take a screenshot of where it came from?
|
|
Assignee | |
Updated•4 years ago
|
|
Reporter | |
Comment 3•4 years ago
|
||
|
|
Assignee | |
Comment 5•4 years ago
|
||
That rule only applies for lwthemes that include images. The text-shadow is white for light coloured backgrounds (to make sure dark text stands out, so you wouldn't notice it in this dialog which is dark-text-on-light-background anyway) and black for dark coloured backgrounds (to make sure light text stands out, which looks really bad here). It should be disabled inside the prompts.
I imagine Mike would have seen this before if this wasn't a recent regression.
|
|
Reporter | |
Comment 6•4 years ago
|
||
Here is a theme that causes it to happen:
https://addons.mozilla.org/en-US/firefox/addon/wine-abstract-light-by-m-donna/
|
|
Assignee | |
Comment 7•4 years ago
|
||
[Tracking Requested - why for this release]:
Unusable prompts with some themes
(still digging to find an actual regressor, but this regressed second half of april)
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 8•4 years ago
|
||
These styles:
Are supposed to stop this, but they don't anymore, because the actual prompt element is no longer a XUL element after the patch from bug 1583696
Matt, :ntim is sick, can you take a look please?
|
||
Comment 9•4 years ago
|
||
I guess we can just add the html| namespace to that existing selector? Paul is this something you could take? I have too much going on this week with the Fx76 release and the merge coming up.
|
|
Assignee | |
Comment 10•4 years ago
|
||
I can take and ask Paul for review.
|
|
Assignee | |
Comment 11•4 years ago
|
||
|
|
Assignee | |
Comment 12•4 years ago
|
||
Bah, actually, there are other issues, e.g. alert("hi".repeat(1000)) gets you a scrollbar on 76 but text escaping the box on nightly (both before and after my patch).
|
|
Assignee | |
Comment 13•4 years ago
|
||
Things that were broken:
- prompts become unreadable when using dark-background lwthemes, because they
keep the window text-shadow (due to the namespace change of tabmodalprompt)
= prompts with long text without word-wrap possibilities
(e.g.alert("x".repeat(1000))) cause the text to escape its container.
|
||
Updated•4 years ago
|
|
||
Comment 14•4 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0af74082185e back out changeset 0aa77ee04caa (bug 1583696) over regressions with overly long non-wrapping prompt text and visual appearance with lightweight themes, r=MattN
|
||
Updated•4 years ago
|
|
||
Comment 15•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Updated•1 year ago
|
Description
•