Closed Bug 1634369 Opened 5 years ago Closed 5 years ago

web-platform/tests/battery-status/* all fail due to missing getBattery() function

Categories

(Core :: DOM: Device Interfaces, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file)

I was investigating a timeout in battery-status tests and realized that all the tests are expected fail and the few subtests that are not expected fail are error conditions or not related to battery-status.

It appears we have or had support for getBattery() as per bug 1050749.

Either this isn't supported by Firefox anymore, or the tests are broken.

I would like to determine if we support getBattery() on a canvas:

  1. supported (and we need to fix the tests)
  2. not [fully] supported, but on a roadmap in the next year (run the tests as 'backlog' on m-c only)
  3. no plans to support this (stop running the tests altogether)
Flags: needinfo?(dmu)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #0)

I was investigating a timeout in battery-status tests and realized that all the tests are expected fail and the few subtests that are not expected fail are error conditions or not related to battery-status.

It appears we have or had support for getBattery() as per bug 1050749.

Either this isn't supported by Firefox anymore, or the tests are broken.

I would like to determine if we support getBattery() on a canvas:

  1. supported (and we need to fix the tests)
  2. not [fully] supported, but on a roadmap in the next year (run the tests as 'backlog' on m-c only)
  3. no plans to support this (stop running the tests altogether)

Hi Joel,
It looks like getBattery() is supported in FF 43, so we can verify which testes should be enabled or disabled. We might have some unfinished features of Battery APIs. But, I don't think we would have other resource who can work on this recently. The original authors are inactive now.

Flags: needinfo?(dmu)
Priority: -- → P5
Priority: P5 → P4

:daoshengmu, thanks for the reply, we need to fix, disable, or reduce the timeout tests- as you indicated nobody has the expertise- is there someone that can figure it out this week?

I would guess we don't want to enable this for fingerprinting reasons, although I can't see a standards-position on it. My expectation is that we can mark it as backlog for now and try to figure out if we can move to not-implementing.

When running tests, please make sure dom.battery.enabled;true [1]. If they still have uncertain cases, I would agree with :jgraham, we can put it as backlog.

[1] https://searchfox.org/mozilla-central/rev/7908ce29657cfd623993046bd8e38664e1c0b28e/modules/libpref/init/StaticPrefList.yaml#1409

battery-status tests are not passing, move to backlog (tier-2)

Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7897d503cd3a battery-status tests are not passing, move to backlog (tier-2). r=jgraham
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: