Closed Bug 1634431 Opened 5 years ago Closed 5 years ago

Color of container indicator in tab bar does not update when changing it

Categories

(Firefox :: Tabbed Browser, defect)

76 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: mail, Assigned: Gijs)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

Using multi-account containers, open a tab in any container, then go to your settings and change the color for that container

Actual results:

The colored bar in the tab indicating what container is used did not update until reopening the tab

(it is unknown if this behaviour is avoided by closing any tab or closing all tabs of a container)

Expected results:

The colored bar in the tab indicating what container is used should change color to reflect the new setting

Attached video demonstration (deleted) —

Demonstration of the bug

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Tabbed Browser

(In reply to Anselm Schüler from comment #0)

(it is unknown if this behaviour is avoided by closing any tab or closing all tabs of a container)

It is. See attached video.

Status: UNCONFIRMED → NEW
Ever confirmed: true

Is this a regression? ISTR this used to work, but I could well be wrong...

I think this is not a regression. I can reproduce the issue on Nightly66.0a1(20190128092811) Windows10.

Attached video demonstration-of-other-situation (deleted) —

demonstration-of-other-situation

Tab color does update on the tab the settings page is in. See uploaded video.

(In reply to Anselm Schüler from comment #7)

Tab color does update on the tab the settings page is in. See uploaded video.

This does not invalidate this issue

There's code to do this but the code is just horribly broken.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

Looks like bug 1344519 changed the observer notification but didn't update the tabbrowser consumer, and there were no tests.

Regressed by: 1344519
Has Regression Range: --- → yes
Keywords: regression
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d2032ecd7540 actually update tab colours when container data changes, r=dao
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: