Closed Bug 1634542 Opened 5 years ago Closed 4 years ago

Profiler popup needs to disable recording when a private browsing window is open

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

defect

Tracking

(firefox78 fixed)

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

Details

Attachments

(2 files)

Steps to reproduce:

  • Enable the profiler menu button
  • Open a private browser
  • Open popup and click "Start recording"

Expected result:

The button is inactive

Actual Result:

Exception while trigerring key [object Object]: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIProfiler.StartProfiler]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: resource://devtools/client/performance-new/popup/background.jsm.js :: startProfiler :: line 285"  data: no]
startProfiler@resource://devtools/client/performance-new/popup/background.jsm.js:285:21

The severity field is not set for this bug.
:julienw, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(felash)
Severity: -- → S3
Flags: needinfo?(felash)
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f8c55a7aecb Teach the profiler popup about private browsing; r=canaltinova https://hg.mozilla.org/integration/autoland/rev/9ac5844267e7 Add a test for the private browsing popup support; r=canaltinova
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: