Closed Bug 1634700 Opened 5 years ago Closed 5 years ago

Handle edge case in update of MLBF-based blocklist

Categories

(Toolkit :: Blocklist Implementation, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

Details

Attachments

(2 files)

In theory, it is possible to have the same multi-layered bloom filter (MLBF) for different sets of inputs, because new additions could already be covered by existing bloom filters.

This situation does currently not happen in practice, because the backend uses a new salt (for its salted hashes) to generate the bloom filter.

But it would be nice to address it.

Emphasize that signedDate is a Date instance instead of a number.

And replace check for signedState with signedDate, because the latter
captures my intent (the original implementation checked signedState
because signedDate used to unconditionally return a Date instance,
even for invalid dates, but that was changed in bug 1583844).

Attachment #9145034 - Attachment description: Bug 1634700 - signedDate is a Date, not a number → Bug 1634700 - Treat signedDate as a Date instead of a number in the blocklist
Attachment #9145035 - Attachment description: Bug 1634700 - Pick up generation_time if needed → Bug 1634700 - Always use latest generation_time in MLBF blocklist updates
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/05fa5a623f24 Treat signedDate as a Date instead of a number in the blocklist r=Gijs https://hg.mozilla.org/integration/autoland/rev/22b221cc4265 Always use latest generation_time in MLBF blocklist updates r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: