Handle edge case in update of MLBF-based blocklist
Categories
(Toolkit :: Blocklist Implementation, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: robwu, Assigned: robwu)
References
Details
Attachments
(2 files)
In theory, it is possible to have the same multi-layered bloom filter (MLBF) for different sets of inputs, because new additions could already be covered by existing bloom filters.
This situation does currently not happen in practice, because the backend uses a new salt (for its salted hashes) to generate the bloom filter.
But it would be nice to address it.
Assignee | ||
Comment 1•5 years ago
|
||
Emphasize that signedDate
is a Date
instance instead of a number.
And replace check for signedState with signedDate, because the latter
captures my intent (the original implementation checked signedState
because signedDate used to unconditionally return a Date
instance,
even for invalid dates, but that was changed in bug 1583844).
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/05fa5a623f24
https://hg.mozilla.org/mozilla-central/rev/22b221cc4265
Description
•