Closed Bug 1634887 Opened 5 years ago Closed 5 years ago

RNP build fails with gcc compiler

Categories

(Thunderbird :: Build Config, defect, P2)

Product:
Thunderbird
Component:
Build Config
Type:
defect

Tracking

(thunderbird77 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 78.0
Tracking Flags:
Tracking Status
thunderbird77 --- fixed

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(1 file)

Drop use of -fcxx-exceptions flag for gcc
(deleted), patch
darktrojan
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review

make[4]: Entering directory '/NEW-SSD/moz-obj-dir/objdir-tb3/comm/third_party/rnp'
Makefile:18: warning: overriding recipe for target 'librnp.so'
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/config/rules.mk:608: warning: ignoring old recipe for target 'librnp.so'
comm/third_party/rnp/config.h.stub
/NEW-SSD/moz-obj-dir/objdir-tb3/_virtualenvs/init_py3/bin/python -m mozbuild.action.file_generate /NEW-SSD/NREF-COMM-CENTRAL/mozilla/python/mozbuild/mozbuild/action/process_define_files.py process_define_file src/lib/config.h src/lib/.deps/config.h.pp src/lib/.deps/config.h.stub /NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/third_party/rnp/src/lib/config.h.in
make[4]: Leaving directory '/NEW-SSD/moz-obj-dir/objdir-tb3/comm/third_party/rnp'

The error about overriding the recipe for the librnp.so target should be addressed by bug 1634209

Assignee: nobody → rob
Blocks: pgp
Severity: -- → S4
Priority: -- → P2
This is a build fix for gcc. This flag doesn't exist for gcc, and is the default behavior with clang. It is needed for clang-cl when building for Windows though.
Attachment #9145889 - Flags: review?(geoff)
Attachment #9145889 - Flags: review?(geoff) → review+
Keywords: checkin-needed-tb
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 78.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/11757d68b872
Drop use of -fcxx-exceptions flag - makes RNP build with gcc. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Comment on attachment 9145889 [details] [diff] [review] Drop use of -fcxx-exceptions flag for gcc Request to uplift OpenPGP improvements to Beta 77 Bug 1 of 9 https://hg.mozilla.org/comm-central/rev/11757d68b872 [Approval Request Comment] Testing completed (on c-c, etc.): yes Risk to taking this patch (and alternatives if risky): only affects openpgp
Attachment #9145889 - Flags: approval-comm-beta?
Comment on attachment 9145889 [details] [diff] [review] Drop use of -fcxx-exceptions flag for gcc Approved for beta
Attachment #9145889 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: