"Initially Show Attachment Pane" option not working after Enigmail integration (also not working in TB 68 with Enigmail).
Categories
(Thunderbird :: Message Compose Window, defect, P1)
Tracking
(thunderbird78 fixed)
| Tracking | Status | |
|---|---|---|
| thunderbird78 | --- | fixed |
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
mkmelin
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
If you right-click on the attachment pane header, you get and option "Initially Show Attachment Pane". If selected, new compose windows should start with the attachment pane already open. That worked for a while after the feature was implemented. It seems to have gone broken, just like opening and closing an empty area broke, bug 1613284.
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 1•4 years ago
|
||
Since apparently nobody missed it, we could probably do without.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Enigmail integration broke this:
If the preferences is set, we see this call stack:
=== toggleAttachmentPane show
== JS stack> chrome://messenger/content/messengercompose/MsgComposeCommands.js (6524)
== JS stack> chrome://messenger/content/messengercompose/MsgComposeCommands.js (3631)
== JS stack> chrome://messenger/content/messengercompose/MsgComposeCommands.js (3912)
== JS stack> chrome://messenger/content/messengercompose/messengercompose.xhtml(1)
coming from https://searchfox.org/comm-central/rev/024cb64ede43e4cfca243bf69e75c75a31d39adc/mail/components/compose/content/MsgComposeCommands.js#3631
Shortly after we get:
=== toggleAttachmentPane hide
== JS stack> chrome://messenger/content/messengercompose/MsgComposeCommands.js (6524)
== JS stack> chrome://messenger/content/messengercompose/MsgComposeCommands.js (6144)
== JS stack> chrome://messenger/content/messengercompose/MsgComposeCommands.js (6105)
== JS stack> chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js (794)
== JS stack> chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js (226)
coming from:
https://searchfox.org/comm-central/rev/024cb64ede43e4cfca243bf69e75c75a31d39adc/mail/extensions/openpgp/content/ui/enigmailMsgComposeOverlay.js#794
This is a regression and the statement
Since apparently nobody missed it, we could probably do without.
is wrong. It still works in TB 68 as long as Enigmail isn't installed.
|
|
Assignee | |
Comment 3•4 years ago
|
||
I'm really not pleased that the Enigmail code has just been committed to the source tree without a proper review by a Compose peer. It doesn't take much digging to find more issues :-(
I'm also not pleased that defects get assigned incorrect priorities without taking the time to at least look at the issue, and yes, my fault, I had messed up the description. Regression that are visible in the UI within 30 seconds of use of course need to be fixed, even if they only affect a minority of users. Attachment handling is clearly an enterprise feature and it is well imaginable that this option is used by some.
Magnus, please assign a resource to give the Enigmail compose code a thorough review.
|
|
||
Comment 4•4 years ago
|
||
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 5•4 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/6a2b0a6335ab
Re-instate 'Initially Show Attachment Pane' option. r=mkmelin
|
||
Comment 7•4 years ago
|
||
|
||
Comment 8•4 years ago
|
||
| bugherder uplift | ||
Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/e149840af8ce
|
|
||
Updated•4 years ago
|
Description
•