Closed
Bug 1635271
Opened 5 years ago
Closed 5 years ago
`mach configure` after `mach clobber` ends up with extra `-fPIC` argument
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox78 fixed)
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
I noticed a weirdness in mach configure where my test builds were getting different OS_CFLAGS on different runs. I tracked it down to not restoring CFLAGS, so this is fallout from Bug 1524461. What happens is that after a clobber, there's no configure cache, and therefore the CFLAGS get tweaked; but running configure again, the cache steps in and the extra -fPIC isn't present.
|
Assignee | |
Comment 1•5 years ago
|
||
If we don't restore CFLAGS, then after a clobber, there's no configure
cache, and therefore the CFLAGS get tweaked. But running configure
again, the cache steps in and the extra -fPIC isn't added. Locally
this means fewer sccache hits (but in automation, all builds at this
time are clobber builds, so there's no impact).
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7af7b4435997
Restore CFLAGS to avoid repeat -fPIC flag when running configure after clobber. r=froydnj
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•