Closed Bug 1635670 Opened 5 years ago Closed 2 years ago

Force sRGB tag for screenshots as generated with "WebDriver:TakeScreenshot"

Categories

(Remote Protocol :: Marionette, defect, P2)

Version 3
defect

Tracking

(firefox76 unaffected, firefox77 wontfix, firefox78 affected)

RESOLVED INACTIVE
Tracking Status
firefox76 --- unaffected
firefox77 --- wontfix
firefox78 --- affected

People

(Reporter: whimboo, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Since full color management (bug 455077) has been landed in Firefox our screenshot code could produce incorrectly tagged images. Especially if the display isn't sRGB, which mostly happens under MacOS. For details see bug 1631089 comment 15.

I wonder if a wdspec test might be useful here, which has a pre-created reference image similarly to the Puppeteer unit test. That way we could check for equality even without having to deeply analyze the image like the tag, and colors of each pixel.

James, what do you think? I don't see problems for Chrome, but maybe we should talk with Brian in regards of Safari.

Flags: needinfo?(james)

I think I might argue that WebDriver doesn't specifically require that you do anything in particular with colour management, so a test requiring specific behaviour seems dubious. But we could definitely have a Firefox-only test for this.

Flags: needinfo?(james)

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hskupin)
Severity: -- → S3
Flags: needinfo?(hskupin)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INACTIVE
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.