Open
Bug 1635741
Opened 5 years ago
Updated 2 years ago
[Hero Layout] Small cards domain has line-height of 20px
Categories
(Firefox :: New Tab Page, defect, P3)
Tracking
()
NEW
People
(Reporter: vvalentina, Assigned: gsuntop)
References
Details
Attachments
(1 file)
(deleted),
image/png
|
Details |
[Affected versions]:
- Firefox Beta 77.0a1 Build ID 20200505174119;
[Affected Platforms]:
- Windows 10;
- Mac OS 10.14;
- Ubuntu 18.04 x64;
[Prerequisites]:
- Have a Firefox Beta 77 build installed;
- Have a new profile created;
- Have the following prefs set in about:config
--Browser.search.region to “US”
--Browser.newtabpage.activity-stream.discoverystream.spocs-endpoint to https://spocs.getpocket.com/spocs?country=US®ion=US-CA
--Browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":true,"layout_endpoint":"https://getpocket.cdn.mozilla.net/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=hero-layout","unused_key":"unused_2"}
[Steps to reproduce]:
- Open the browser with the profile from prerequisites.
- Open about:newtab page.
- Tap “F12” key to open the browser Inspector.
- Observe the line-height of cards domain.
[Expected result]:
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1628045#c6 line-height in small cards should be 19px.
[Actual result]:
Line-height for small cards domain is 20px.
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(tmiller)
Comment 1•5 years ago
|
||
Thanks for catching this Valentina. The intent here is to match the components that are already built and the Firefox Design System, and if 20 is in the existing component that's fine. The spec has the line height as 140% (as described in the Firefox design system) which is closer to 19 than 20, but 20 is good here.
Flags: needinfo?(tmiller)
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → gsuntop
Priority: -- → P3
Comment 2•2 years ago
|
||
If this issue is available I'd take it, if anyone sees this could you please assign me.. Thanks
You need to log in
before you can comment on or make changes to this bug.
Description
•