Import AB fr Outlook Ex.:Non-ascii list (group) name doesn't show Build: 0819 branch Observed: on JA windows Xp and 98 Steps: 1. Using Outlook Express, create a contact with JA chars. 2. Also create a group with JA name and include the contact created in step 1 3. From branch build mail, go to Tools|Import 4. Select Address Books and then Outlook Express. 5. You'll see a msg indicating "import was successful." 6. Notice that the group name (called list in our AB) isn't showing and its associated contact (card) is missing. Note: When the group has EN name, the name itself is showing in AB after importing process although its associated contact is still missing (this is a separate core bug)

Notice that the first entry which is a list is missing its JA name and its cards.

QA contact over to me.

Importing from Outlook has the same problem. Change the summary accordingly.

nominating....

Reassign to cavin.

*** Bug 174436 has been marked as a duplicate of this bug. ***

Use Assign(NS_ConvertUCS2toUTF8()) instead of AssignWithConversion() for list name setting.

Comment on attachment 103268 [details] [diff] [review] Proposed patch. r=nhotta

Do the same thing for Outlook as well.

Comment on attachment 103391 [details] [diff] [review] Proposed patch, v2 r=nhotta

nsCAutoString column; - column.AssignWithConversion(pName); + column.Assign(NS_ConvertUCS2toUTF8(pName)); do we even need the column local var? can't we just do: rv = pDb->AddListName(newRow, NS_ConvertUCS2toUTF8(pName));

Yes, we can. Do I need to post another patch or I can just change it before checking it in?

no need for a new patch. just change it before checking in (to trunk and branches)

Adding [fixedish1] to status whiteboard.

On the build containing the fix, the Japanese list name is imported correctly either from OE or Outlook Express. But the contacts on the list are still missing.

> But the contacts on the list are still missing. > This is bug 149961.

Fix checked in to the trunk.