Restore py2 compatibility in xpidl.py (SearchFox May 7 indexing failure)
Categories
(Core :: XPCOM, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox75 | --- | unaffected |
firefox76 | --- | unaffected |
firefox77 | --- | unaffected |
firefox78 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Filing in advance because I had a test run today fail and I'm sure the indexer tomorrow will fail in the same way. This is because xpidl.py got updated in m-c to require python3 or something, and we run with idl-analyze.py using python2.
Traceback (most recent call last):
File "/home/ubuntu/mozsearch/scripts/idl-analyze.py", line 2, in <module>
import xpidl
File "/tmp/pymodules/xpidl.py", line 138
self.location, warning=True), file=sys.stderr)
^
SyntaxError: invalid syntax
Assignee | ||
Comment 1•4 years ago
|
||
This is a bit tricky because xpidl.py is going to be py3 in m-c but remain py2 in m-b, m-r, and esr branches. So we'll need to deal with both. One path forward is to make py2 and py3 versions of idl-analyze.py
and invoke the appropriate one depending on which version of xpidl.py
we're dealing with.
Eventually of course it would be nice to run this on the taskcluster job instead so it stays in sync with whatever upstream is doing, but in the short-term we can do this to get the indexer unbroken (hopefully) without loss of functionality.
Assignee | ||
Comment 2•4 years ago
|
||
After some experimentation with py3 conversion I think the fact that xpidl.py is not py2 compatible might be unintentional and can be easily fixed.
Assignee | ||
Comment 3•4 years ago
|
||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
bugherder |
Comment 6•4 years ago
|
||
Set release status flags based on info from the regressing bug 1634864
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•3 years ago
|
Description
•