In the search service we override which locale is loaded for an add-on and use the manifest for the locale we want. This lets us be more flexible around how search engines are deployed.

In Yandex's case (I think the only case) we have two engine icons, one for the en engine, one for ru.

When the locale is different from the in-use locale, we're picking up the default icon yandex-en.ico rather than yandex-ru.ico.

I think this only affects a single Yandex distribution (yandex-uk). Petrua reported this in bug 1635154 comment 6.

Backed out changeset edd5fdedad45 for causing bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f0d22d026e74b1764c96f9bf18f69df3599542e0

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=b8a583d8b972c7cab3f6103cc9fa113463ebd43c&fromchange=8724751e26c9b0d40bc174968fc5f4bae36e653c

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301727863&repo=autoland&lineNumber=68161

[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests> /builds/worker/workspace/obj-build/_virtualenvs/init_py3/bin/python -m mozbuild.action.process_install_manifest --track install__test_files.track _tests _build_manifests/install/_test_files
[task 2020-05-11T13:41:52.104Z] 13:41:52    ERROR -  package-tests> Traceback (most recent call last):
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>   File "/usr/lib/python3.5/runpy.py", line 193, in _run_module_as_main
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>     "__main__", mod_spec)
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>   File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>     exec(code, run_globals)
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/process_install_manifest.py", line 114, in <module>
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>     main(sys.argv[1:])
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/process_install_manifest.py", line 100, in main
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>     defines=args.defines)
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/process_install_manifest.py", line 69, in process_manifest
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>     remove_empty_directories=remove_empty_directories)
[task 2020-05-11T13:41:52.104Z] 13:41:52     INFO -  package-tests>   File "/builds/worker/checkouts/gecko/python/mozbuild/mozpack/copier.py", line 424, in copy
[task 2020-05-11T13:41:52.105Z] 13:41:52     INFO -  package-tests>     copy_results.append((destfile, f.copy(destfile, skip_if_older)))
[task 2020-05-11T13:41:52.105Z] 13:41:52     INFO -  package-tests>   File "/builds/worker/checkouts/gecko/python/mozbuild/mozpack/files.py", line 386, in copy
[task 2020-05-11T13:41:52.105Z] 13:41:52     INFO -  package-tests>     raise ErrorMessage('Symlink target path does not exist: %s' % self.path)
[task 2020-05-11T13:41:52.105Z] 13:41:52     INFO -  package-tests> mozpack.errors.ErrorMessage: Symlink target path does not exist: /builds/worker/checkouts/gecko/toolkit/components/search/tests/xpcshell/test-extensions/multilocale/favicon-an.ico
[task 2020-05-11T13:41:52.105Z] 13:41:52     INFO -  package-tests> Makefile:119: recipe for target 'install-test-files' failed
[task 2020-05-11T13:41:52.105Z] 13:41:52    ERROR -  package-tests> make[2]: *** [install-test-files] Error 1
[task 2020-05-11T13:41:52.105Z] 13:41:52     INFO -  package-tests> make[2]: Leaving directory '/builds/worker/workspace/obj-build'
[task 2020-05-11T13:41:52.105Z] 13:41:52     INFO -  /builds/worker/checkouts/gecko/build/moz-automation.mk:105: recipe for target 'automation/package-tests' failed
[task 2020-05-11T13:41:52.105Z] 13:41:52    ERROR -  make[1]: *** [automation/package-tests] Error 2
[task 2020-05-11T13:41:52.105Z] 13:41:52     INFO -  make[1]: *** Waiting for unfinished jobs....

Oops, that's an untracked file on my hard drive :-(

https://hg.mozilla.org/mozilla-central/rev/acf48f417a99

Verified with Nightly 78.0a1 2020-05-11 that Yandex uk-UA has the right icon. Also checked that nothing changed for various other Yandex distributions.