Closed
Bug 1636057
Opened 5 years ago
Closed 5 years ago
Make arrow panel opening animation obey prefers-reduced-motion
Categories
(Toolkit :: XUL Widgets, enhancement, P1)
Toolkit
XUL Widgets
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Keywords: access)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/37298a30f66d
Make arrow panel opening animation obey prefers-reduced-motion. r=Gijs
|
||
Comment 3•5 years ago
|
||
Backed out changeset 37298a30f66d (bug 1636057) for xpcshell failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/cc2d8256440757af8a1dda8ff37fd8047b44cb44
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302233895&repo=autoland&lineNumber=2459
[task 2020-05-14T10:13:16.430Z] 10:13:16 INFO - TEST-START | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_indexedDB_principal.js
[task 2020-05-14T10:13:17.653Z] 10:13:17 WARNING - TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_indexedDB_principal.js | xpcshell return code: 139
[task 2020-05-14T10:13:17.653Z] 10:13:17 INFO - TEST-INFO took 1223ms
[task 2020-05-14T10:13:17.653Z] 10:13:17 INFO - >>>>>>>
[task 2020-05-14T10:13:17.653Z] 10:13:17 INFO - xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_indexedDB_principal.js | xpcw: cd /data/local/tmp/tests/xpc/toolkit/components/extensions/test/xpcshell
[task 2020-05-14T10:13:17.654Z] 10:13:17 INFO - xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_indexedDB_principal.js | xpcw: xpcshell -r /data/local/tmp/tests/xpc/c/httpd.manifest --greomni /data/local/xpcb/geckoview-androidTest.apk -m -e const _HEAD_JS_PATH = "/data/local/tmp/tests/xpc/head.js"; -e const _MOZINFO_JS_PATH = "/data/local/tmp/tests/xpc/p/mozinfo.json"; -e const _PREFS_FILE = "/data/local/tmp/tests/xpc/tmp/user.js"; -e const _TESTING_MODULES_DIR = "/data/local/tmp/tests/xpc/m"; -f /data/local/tmp/tests/xpc/head.js -e const _HEAD_FILES = ["/data/local/tmp/tests/xpc/toolkit/components/extensions/test/xpcshell/head.js", "/data/local/tmp/tests/xpc/toolkit/components/extensions/test/xpcshell/head_telemetry.js"]; -e const _JSDEBUGGER_PORT = 0; -e const _TEST_FILE = ["test_ext_indexedDB_principal.js"]; -e const _TEST_NAME = "xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_indexedDB_principal.js"; -e _execute_test(); quit(0);
[task 2020-05-14T10:13:17.655Z] 10:13:17 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-05-14T10:13:17.655Z] 10:13:17 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2020-05-14T10:13:17.655Z] 10:13:17 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-05-14T10:13:17.655Z] 10:13:17 INFO - running event loop
[task 2020-05-14T10:13:17.655Z] 10:13:17 INFO - xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_indexedDB_principal.js | Starting check_remote
[task 2020-05-14T10:13:17.655Z] 10:13:17 INFO - (xpcshell/head.js) | test check_remote pending (2)
[task 2020-05-14T10:13:17.655Z] 10:13:17 INFO - TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_indexedDB_principal.js | check_remote - [check_remote : 1] useRemoteWebExtensions matches - false == false
[task 2020-05-14T10:13:17.656Z] 10:13:17 INFO - TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_indexedDB_principal.js | check_remote - [check_remote : 1] testing from extension process - true == true
[task 2020-05-14T10:13:17.656Z] 10:13:17 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2020-05-14T10:13:17.656Z] 10:13:17 INFO - (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2020-05-14T10:13:17.656Z] 10:13:17 INFO - (xpcshell/head.js) | test check_remote finished (2)
[task 2020-05-14T10:13:17.656Z] 10:13:17 INFO - xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_indexedDB_principal.js | Starting test_indexedDB_principal
[task 2020-05-14T10:13:17.656Z] 10:13:17 INFO - (xpcshell/head.js) | test test_indexedDB_principal pending (2)
[task 2020-05-14T10:13:17.657Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195821 addons.manager DEBUG Application has been upgraded"
[task 2020-05-14T10:13:17.657Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195822 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider", "XPIInternal"]"
[task 2020-05-14T10:13:17.657Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195822 addons.manager DEBUG Starting provider: XPIProvider"
[task 2020-05-14T10:13:17.657Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195822 addons.xpi DEBUG startup"
[task 2020-05-14T10:13:17.657Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195824 addons.xpi INFO SystemAddonLocation directory is missing"
[task 2020-05-14T10:13:17.657Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195834 addons.xpi INFO Removing all system add-on upgrades."
[task 2020-05-14T10:13:17.658Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195835 addons.xpi DEBUG checkForChanges"
[task 2020-05-14T10:13:17.658Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195835 addons.xpi DEBUG Loaded add-on state: ${}"
[task 2020-05-14T10:13:17.658Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195835 addons.xpi DEBUG scanForChanges changed: false, state: {}"
[task 2020-05-14T10:13:17.658Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195836 addons.xpi DEBUG Empty XPI database, setting schema version preference to 32"
[task 2020-05-14T10:13:17.658Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195836 addons.xpi DEBUG No changes found"
[task 2020-05-14T10:13:17.658Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195846 addons.xpi-utils DEBUG Synchronously loading the add-ons database"
[task 2020-05-14T10:13:17.659Z] 10:13:17 INFO - "CONSOLE_MESSAGE: (info) 1589451195847 addons.xpi-utils DEBUG Starting async load of XPI database /data/local/tmp/tests/xpc/p/extensions.json"
[task 2020-05-14T10:13:17.659Z] 10:13:17 INFO - (xpcshell/head.js) | test run_next_test 1 finished (2)
...
Flags: needinfo?(dao+bmo)
|
|
||
Comment 4•5 years ago
|
||
The following failures seem to start with the backed out changes:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302233699&repo=autoland&lineNumber=1583
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302233694&repo=autoland&lineNumber=2254
|
|
Assignee | |
Comment 5•5 years ago
|
||
(In reply to Bogdan Tara[:bogdan_tara | bogdant] from comment #3)
Backed out changeset 37298a30f66d (bug 1636057) for xpcshell failures
That's on Android. This patch affects desktop Firefox only.
Flags: needinfo?(dao+bmo) → needinfo?(btara)
|
||
Comment 6•5 years ago
|
||
Treeherder shows it starting with the push for this bug and getting fixed with the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&searchStr=android%2Cxpcshell&fromchange=17cfe5578adfba438a6c39c125e33efb5c1262f8&tochange=cc2d8256440757af8a1dda8ff37fd8047b44cb44&selectedTaskRun=Z56DUVkHTjKYKAnDWP7cIQ-0
Geoff, any ideas why this patch fails Android XPCshell tests?
Flags: needinfo?(btara) → needinfo?(gbrown)
|
||
Comment 7•5 years ago
|
||
The top of the crash stack is:
[task 2020-05-14T10:37:39.286Z] 10:37:39 INFO - 0 libxul.so!mozilla::jni::GetEnvForThread() [Utils.cpp:37298a30f66d17d8cd0eebfb7776cd7ac1336112 : 159 + 0x29]
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - rax = 0x00007c0df30416f3 rdx = 0x0000000000000004
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - rcx = 0x00007c0de8645bf0 rbx = 0x000000000000003b
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - rsi = 0x00007fffc5fe7cf0 rdi = 0x0000000000000003
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - rbp = 0x00007fffc5fe8e20 rsp = 0x00007fffc5fe8e10
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - r8 = 0x000000000000ffff r9 = 0x0000000000000000
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - r10 = 0x00007c0de559e540 r11 = 0x0000000000000246
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - r12 = 0x00007c0ddbb65890 r13 = 0x00007c0ddbb65806
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - r14 = 0x00007fffc5fe8e94 r15 = 0x00007c0ddbd202d0
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - rip = 0x00007c0dee758e0c
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - Found by: given as instruction pointer in context
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - 1 libxul.so!mozilla::java::GeckoSystemStateListener::PrefersReducedMotion() [GeneratedJNIGeckoSystemStateListenerWrappers.cpp: : 42 + 0xd]
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - rbp = 0x00007fffc5fe8e50 rsp = 0x00007fffc5fe8e30
[task 2020-05-14T10:37:39.287Z] 10:37:39 INFO - rip = 0x00007c0dee6e50b2
[task 2020-05-14T10:37:39.288Z] 10:37:39 INFO - Found by: previous frame's frame pointer
[task 2020-05-14T10:37:39.288Z] 10:37:39 INFO - 2 libxul.so!nsLookAndFeel::GetIntImpl(mozilla::LookAndFeel::IntID, int&) [nsLookAndFeel.cpp:37298a30f66d17d8cd0eebfb7776cd7ac1336112 : 387 + 0x5]
[task 2020-05-14T10:37:39.288Z] 10:37:39 INFO - rbp = 0x00007fffc5fe8e80 rsp = 0x00007fffc5fe8e60
[task 2020-05-14T10:37:39.288Z] 10:37:39 INFO - rip = 0x00007c0dee737c27
[task 2020-05-14T10:37:39.288Z] 10:37:39 INFO - Found by: previous frame's frame pointer
[task 2020-05-14T10:37:39.288Z] 10:37:39 INFO - 3 libxul.so!Gecko_MediaFeatures_PrefersReducedMotion [nsMediaFeatures.cpp:37298a30f66d17d8cd0eebfb7776cd7ac1336112 : 240 + 0x15]
[task 2020-05-14T10:37:39.288Z] 10:37:39 INFO - rbp = 0x00007fffc5fe8ea0 rsp = 0x00007fffc5fe8e90
[task 2020-05-14T10:37:39.288Z] 10:37:39 INFO - rip = 0x00007c0dee90e407
[task 2020-05-14T10:37:39.288Z] 10:37:39 INFO - Found by: previous frame's frame pointer
So it looks like the xpcshell test creates a windowless browser for some extension code, and that presumably loads xul.css, which tries to evaluate the media query, and becomes Very Sad. About something - unclear what, I haven't looked into the jni stuff.
|
|
||
Comment 8•5 years ago
|
||
Sorry, I have no additional insight. :snorp or :agi might?
If the change is intended for desktop only, maybe it should just be guarded with an %ifdef?
Flags: needinfo?(gbrown)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/697deb14f276
Make arrow panel opening animation obey prefers-reduced-motion. r=Gijs
|
||
Comment 11•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•