rollup popups on direct manipulation event
Categories
(Core :: Widget: Win32, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
|
Assignee | |
Comment 1•4 years ago
|
||
Direct Manipulation uses a different input model from processing messages that Windows sends.
Windows asks us if we want to start a direct manipulation session by sending us the DM_POINTERHITTEST message, and we call SetContact if we do. After that Windows won't send us messages until the user ends the gesture. Instead Direct Manipulation will update a transform (that's invisible to the user). We pull that transform and turn it into pan and pinch gestures.
So DealWithPopups is not called and popups don't get rolled up. Instead I call it in the function where we send all events that come from dmanip.
Depends on D73220
|
||
Updated•4 years ago
|
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/804dc7924101 Rollup popups on direct manipulation event. r=NeilDeakin
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
|
||
Comment 4•4 years ago
|
||
What was the problem this bug was trying to solve? i.e. why do we want to roll up popups on dmanip events at all?
|
|
||
Comment 5•4 years ago
|
||
Ah, I see that without this patch scrolling the page hosting an open select popup leaves the popup open and "detaches" it from where it's supposed to be. I guess that's what this patch was supposed to fix. So refining my needinfo to confirm this, and to check if there any other issues you noticed that were fixed by this patch.
|
|
Assignee | |
Comment 6•4 years ago
|
||
Yes, that scrolling and pinch zooming leaves open select dropdowns detached from the triggering content.
|
||
Comment 7•4 years ago
|
||
Did the fix not land in 80 stable? I have this bug and direct manipulation is enabled by default.
|
|
Assignee | |
Comment 8•4 years ago
|
||
(In reply to Poopooracoocoo from comment #7)
Did the fix not land in 80 stable? I have this bug and direct manipulation is enabled by default.
Direct manipulation is not enabled by default in stable, it's only enabled in nightly.
|
|
||
Comment 9•4 years ago
|
||
You're right. I only experienced this bug when direct manipulation was enabled. I recently refreshed Firefox and saw this bug so I thought it was enabled as I hadn't gone into about:config since the refresh (until now, to see if it was enabled or not). I'm not sure what happened :/
Description
•