Closed Bug 1636240 Opened 5 years ago Closed 5 years ago

improvements to update_rnp.sh

Categories

(Thunderbird :: Build Config, task)

Product:
Thunderbird
Component:
Build Config
Type:
task

Tracking

(thunderbird77 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 78.0
Tracking Flags:
Tracking Status
thunderbird77 --- fixed

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(2 files)

Add error trap to update_rnp.sh to revert changes
(deleted), patch
KaiE
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review
Add script to generate rnp.symbols file
(deleted), patch
KaiE
: review+
Details | Diff | Splinter Review

I've added a couple of things to update_rnp.sh as I've been working on bug 1634158.

  • Added automatic rollback of the local mercurial checkout in case update_rnp.sh fails part way through.
  • Script to generate rnp.symbols
I did this because for some reason, my first attempt at running update_rnp.sh yesterday failed and left my local tree a mess.
Attachment #9146553 - Flags: review?(kaie)
Assignee: nobody → rob
Status: NEW → ASSIGNED
This is kind of a work in progress, but it's functional enough to share. There are some Python libraries to install via pip. At the moment it leaves behind some lex and yacc like files in the checkout, which I'm not crazy about.
Attachment #9146567 - Flags: review?(kaie)
Attachment #9146553 - Flags: review?(kaie) → review+
Comment on attachment 9146567 [details] [diff] [review] Add script to generate rnp.symbols file I can give you a rubber stamp rs=kaie I cannot easily check if this code is correct.
Attachment #9146567 - Flags: review?(kaie) → review+

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/de5c89a17b43
Add error trap to update_rnp.sh to revert changes. r=kaie
https://hg.mozilla.org/comm-central/rev/f02349f5fac1
Add script to generate rnp.symbols file. r=kaie

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 78.0

deleted

Comment on attachment 9146553 [details] [diff] [review] Add error trap to update_rnp.sh to revert changes Request to uplift OpenPGP improvements to Beta 77 Bug 2 of 9 https://hg.mozilla.org/comm-central/rev/de5c89a17b43 [Approval Request Comment] Testing completed (on c-c, etc.): yes Risk to taking this patch (and alternatives if risky): only affects openpgp
Attachment #9146553 - Flags: approval-comm-beta?
Comment on attachment 9146553 [details] [diff] [review] Add error trap to update_rnp.sh to revert changes Approved for beta
Attachment #9146553 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: