Closed Bug 1636298 Opened 4 years ago Closed 3 years ago

[css-multicol][css-grid][css-flexbox] Investigate adding a CSS 'column-rule-image-source' property

Categories

(Core :: Layout, enhancement, P4)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1725495
Tracking Status
firefox78 --- affected

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 3 obsolete files)

Attached patch column-rule-image-source hack (obsolete) (deleted) — Splinter Review

Based on the discussion in https://github.com/w3c/csswg-drafts/issues/2748 about adding more advanced options for styling gutters/gaps for grid/flexbox, it seems to me that column-rule-*could be used for this (assuming that we add corresponding row-rule-* properties). It appears that there is demand for supporting images though, akin to border-image.

In this patch I added a column-rule-image-source property to experiment with this a bit. It doesn't seem to work for some reason though and I can't figure out why... The CreateBorderImageRenderer/CreateWebRenderCommands calls return success and I've verified that I call AssociateRequestToFrame on the right frame in nsFrame::DidSetComputedStyle (however the imgIRequest::imageStatus appears to be STATUS_NONE at that point, which emilio said was unexpected).

Flags: needinfo?(emilio)

I think this is about the border-image code. You're setting border-width on nsColumnSetFrame::CreateBorderImageRenderers, but not border-style.

I can get it to render multipe things by using a combination of border-width / border-image-width / border-image-repeat / etc.

Flags: needinfo?(emilio)
Depends on: CVE-2020-12407
Attached file Testcase (obsolete) (deleted) —
Attached video Screen capture of rendering above Testcase (obsolete) (deleted) —
Attached file Testcase (deleted) —
Attachment #9149871 - Attachment is obsolete: true
Attachment #9149872 - Attachment is obsolete: true
Attachment #9146624 - Attachment is obsolete: true
Depends on: 1713730
Blocks: 1725495

This is subsumed by bug 1725495 now.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: