Closed
Bug 1636668
Opened 4 years ago
Closed 4 years ago
Move the kInitSaveNativeData setting code into C++ code
Categories
(Core :: Printing: Setup, task, P3)
Core
Printing: Setup
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
(Whiteboard: [print2020_v78])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•4 years ago
|
||
This code could have been moved into nsPrintingPromptService::ShowPageSetupDialog
(the C++ function that the JS code calls). However, since kInitSaveNativeData
for the print dialog is handled in nsPrintDialogX (this constant is only
relevant on macOS), I've moved the kInitSaveNativeData handling in this case
(the print settings dialog) one call deeper, into
nsPrintDialogX::ShowPageSetup, for consistency.
Depends on D74522
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/ebe64667adaa Move the kInitSaveNativeData setting code into C++ code. r=bobowen
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/d82bed3a0d0d 'Bug 1636668 - followup - remove calendar/ usage of gSavePrintSettings. rs=eslint DONTBUILD
You need to log in
before you can comment on or make changes to this bug.
Description
•