Closed
Bug 1636918
Opened 5 years ago
Closed 5 years ago
Add folding for more guard instructions
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Some newly added guard instructions have a MIRType::None result type. That makes is impossible to use foldsTo. So instead pass through the input values. This additionally gives us some correctness/safety benefits, because that makes it harder to wrongly reorder the guard instructions.
|
Assignee | |
Updated•5 years ago
|
Summary: Add folding for more guard instructions. → Add folding for more guard instructions
|
||
Updated•5 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D74704
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D74705
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/acd69c719c1f
Folding for MGuardSpecificAtom. r=jandem
https://hg.mozilla.org/integration/autoland/rev/de44f702be4f
Folding for MGuardValue. r=jandem
https://hg.mozilla.org/integration/autoland/rev/90fc07d2d162
Folding for MGuardNullOrUndefined. r=jandem
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/acd69c719c1f
https://hg.mozilla.org/mozilla-central/rev/de44f702be4f
https://hg.mozilla.org/mozilla-central/rev/90fc07d2d162
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•