Closed Bug 1637396 Opened 5 years ago Closed 5 years ago

Harden loading the search configuration against failures

Categories

(Firefox :: Search, task, P1)

task
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 78
Iteration:
78.2 - May 18 - May 31
Tracking Status
firefox78 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

We've seen in a couple of instances that it is possible for remote settings to return an empty configuration. Although these cases have been resolved, we already have code to manage errors and fallback to the built-in dump.

I'd therefore like to widen that code to include any exception, and also handle the case where the results are empty (which should never happen). This should provide us with a bit more protection in the event something does go wrong, as the search service is an important part of the browser, I think resilience is worth having.

The other case of returning an empty configuration isn't likely to be an issue, however, I think it is still worth hardening, and ensuring we do our best to get valid data, in case we hit something unexpected.

Iteration: 78.1 - May 4 - May 17 → 78.2 - May 18 - May 31
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a7a62797c25 Harden loading the search configuration against failures. r=daleharvey
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: