Closed Bug 1637433 Opened 5 years ago Closed 5 years ago

Stop using Runnable in BackgroundImpl.cpp

Categories

(Core :: IPC, task)

Product:
Core
Component:
IPC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(5 files)

Bug 1637433 - P1. Remove unused MessageLoop. r?nika
(deleted), text/x-phabricator-request
Details
Bug 1637433 - P2. Replace ShutdownBackgroundThreadRunnable with simple task for clarity. r?nika
(deleted), text/x-phabricator-request
Details
Bug 1637433 - P3. Remove unused class. r?nika
(deleted), text/x-phabricator-request
Details
Bug 1637433 - P4. Remove ForceCloseBackgroundActorsRunnable. r?nika
(deleted), text/x-phabricator-request
Details
Bug 1637433 - P5. replace ConnectActorRunnable with lambda. r?nika
(deleted), text/x-phabricator-request
Details

As worked over bug 1592488; some unnecessary runnable and code now exists in BackgrounImpl.cpp.

Would be nice to do without

Depends on D74993

Depends on D74994

Depends on D74995

Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7059b1afe7a6 P1. Remove unused MessageLoop. r=nika https://hg.mozilla.org/integration/autoland/rev/c58ca2f35ed9 P2. Replace ShutdownBackgroundThreadRunnable with simple task for clarity. r=nika https://hg.mozilla.org/integration/autoland/rev/b42efea62259 P3. Remove unused class. r=nika https://hg.mozilla.org/integration/autoland/rev/63e725b2ae8f P4. Remove ForceCloseBackgroundActorsRunnable. r=nika https://hg.mozilla.org/integration/autoland/rev/c0f62d4c134a P5. replace ConnectActorRunnable with lambda. r=nika

Also crashes on [@ nsAutoOwningThread::AssertCurrentThreadOwnsMe(char const*) const]
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302198349&repo=autoland&lineNumber=1260

Flags: needinfo?(jyavenard)
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f77942ac0d07 P1. Remove unused MessageLoop. r=nika https://hg.mozilla.org/integration/autoland/rev/3109b9f1ffdd P2. Replace ShutdownBackgroundThreadRunnable with simple task for clarity. r=nika https://hg.mozilla.org/integration/autoland/rev/aede0382fdef P3. Remove unused class. r=nika https://hg.mozilla.org/integration/autoland/rev/d9253fe58e4c P4. Remove ForceCloseBackgroundActorsRunnable. r=nika https://hg.mozilla.org/integration/autoland/rev/ec45cd61868a P5. replace ConnectActorRunnable with lambda. r=nika
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: