cache block file patch horked support for partial cache entries [large image requests never load once interrupted]. see: http://unagi.mcom.com/~darinf/test2.html stop the page load before the images load, and then press enter in the URL bar after some of the images have started loading. notice that the images that had previously started loading will never load. there's an assertion in the nsDiskCacheStreams.cpp when trying to issue a byte range request to complete the partial cache entry. WARNING: data too large for buffer, file /builds/trunk/mozilla/netwerk/cache/src/nsDiskCacheStreams.cpp, line 648 this error is not propogated correctly in the http code and we just end up never being able to load the image.

investigating...

ok, so this is only a problem when the partial documents are forced to separate disk files. that is, we must have downloaded more than 16k in order for this bug to appear. but, that is the most common case i would imagine, since partial loads usually correspond to large documents.

this patch fixes the problem for me. it is more or less a work in progress, however, becaues it also includes my fix for bug 163841.

-> me

Comment on attachment 96513 [details] [diff] [review] v0 patch r=dougt

the fix for bug 163841 landed on the trunk, so this patch is now smaller but essentially unchanged :)

Comment on attachment 97128 [details] [diff] [review] v1 patch (merged with latest trunk) carrying forward r=dougt

Comment on attachment 97128 [details] [diff] [review] v1 patch (merged with latest trunk) sr=rpotts@netscape.com

waiting for gordon to review this now that he is back...

fixed-on-trunk with mozilla 1.2 alpha freezing this tuesday, i decided to go ahead and land this patch now to ensure some bake time before mozilla 1.2 alpha and to avoid the headache of trying to land this at the last minute. i'm still planning to review these changes with gordon... we can of course always go back and tweak these changes if necessary, but this patch has been tested and seems to fix the regression.

verified trunk - 2002092408 builds - winNT4, linux rh6, mac osX