Closed Bug 1637873 Opened 5 years ago Closed 5 years ago

Destroy RenderTextureHost in TextureHost::Finalize()

Categories

(Core :: Graphics: WebRender, task)

Product:
Core
Component:
Graphics: WebRender
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

Bug 1637873 - Destroy RenderTextureHost in TextureHost::Finalize()
(deleted), text/x-phabricator-request
Details

It is a preparation for Bug 1636868. GPUVideoTextureHost is an exception for now.

Assignee: nobody → sotaro.ikeda.g
Attachment #9148265 - Attachment description: Bug 1637873 - Destroy RenderTextureHost by a TextureHost that created it → Bug 1637873 - Destroy RenderTextureHost in TextureHost::Finalize().
Summary: Destroy RenderTextureHost by a TextureHost that created it → Destroy RenderTextureHost in TextureHost::Finalize()
Blocks: 1636868
Attachment #9148265 - Attachment description: Bug 1637873 - Destroy RenderTextureHost in TextureHost::Finalize(). → Bug 1637873 - Destroy RenderTextureHost in TextureHost::Finalize()
Pushed by sikeda.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5358bc2ae595 Destroy RenderTextureHost in TextureHost::Finalize() r=nical

Backed out for assertion failures on RenderThread.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/59ea188ce47641ed73cfeabe04578990fef96528

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=r%28c%29&revision=5358bc2ae5952a711868e1b2179d037a652c841a&selectedTaskRun=JqY99QzxToGjd4qmbdQdhA-0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302720303&repo=autoland&lineNumber=21153

[task 2020-05-18T10:48:04.152Z] 10:48:04 INFO - 05-18 11:47:23.540 D/SoftwareRenderer( 3133): setting dataspace on output surface to #103
[task 2020-05-18T10:48:04.152Z] 10:48:04 INFO - 05-18 11:47:23.551 F/MOZ_Assert( 2808): Assertion failure: it != mRenderTextures.end(), at /builds/worker/checkouts/gecko/gfx/webrender_bindings/RenderThread.cpp:715
[task 2020-05-18T10:48:04.153Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #01: _ZN13webrender_api3api19NotificationRequest6notify17he75439e388314406E[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x7970c74]
[task 2020-05-18T10:48:04.153Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #02: _ZN9webrender8renderer8Renderer6update17hb778a7f16fd8544fE[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x7872469]
[task 2020-05-18T10:48:04.153Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #03: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x24451a0]
[task 2020-05-18T10:48:04.153Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #04: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x2444ce8]
[task 2020-05-18T10:48:04.153Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #05: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x245388f]
[task 2020-05-18T10:48:04.153Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #06: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x16bbac1]
[task 2020-05-18T10:48:04.153Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #07: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x16bc527]
[task 2020-05-18T10:48:04.153Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #08: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x16bc86b]
[task 2020-05-18T10:48:04.153Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #09: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x16bd4d1]
[task 2020-05-18T10:48:04.154Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #10: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x16bb774]
[task 2020-05-18T10:48:04.154Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #11: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x16bb68e]
[task 2020-05-18T10:48:04.154Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #12: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x16ca08e]
[task 2020-05-18T10:48:04.154Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #13: ???[/data/app/org.mozilla.geckoview.test-1/lib/x86_64/libxul.so +0x16c3a0a]
[task 2020-05-18T10:48:04.154Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #14: ???[/system/lib64/libc.so +0x89772]
[task 2020-05-18T10:48:04.154Z] 10:48:04 INFO - 05-18 11:47:23.552 F/MOZ_Assert( 2808): #15: ???[/system/lib64/libc.so +0x299ec]
[task 2020-05-18T10:48:04.154Z] 10:48:04 INFO - 05-18 11:47:23.553 F/MOZ_Assert( 2808): #16: ???[/system/lib64/libc.so +0x1ca66]
[task 2020-05-18T10:48:04.154Z] 10:48:04 INFO - 05-18 11:47:23.553 F/MOZ_Assert( 2808): #17: ??? (???:???

Flags: needinfo?(sotaro.ikeda.g)

When I tried try tests, the failure did not happen. Recent change around RenderAndroidSurfaceTextureHostOGL might change timing.
It is affected by Bug 1620458.

Pushed by sikeda.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ad0aa8b8d96 Destroy RenderTextureHost in TextureHost::Finalize() r=nical

https://hg.mozilla.org/mozilla-central/rev/5ad0aa8b8d96

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: