Pete Zha Reporter
	Description • 22 years ago

This bug is different with bug 156982. I will upload a testcase for this.
The testcase include a fixed DIV element. Please make sure your window's size is
small enough to see the scrollbar of the DIV before print preview.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1b) Gecko/20020821
Reproduce step: (Always if the window is small enough to see the scrollbar of
the fixed DIV element)
1) Open the first attachment
2 [details] [diff] [review]) Click print preview
3) Click "Close"

Browser will crash.

	Pete Zha Reporter
	Comment 2 • 22 years ago

Fix the crash.

	Pete Zha Reporter
	Comment 3 • 22 years ago

Comment on attachment 96134 [details] [diff] [review]
patch

rods, carry your r= in bug 156982 to have this one to be fixed quickly. Is it
OK?

	Johnny Stenback (:jst)
	Comment 4 • 22 years ago

Comment on attachment 96134 [details] [diff] [review]
patch

sr=jst

	Pete Zha Reporter
	Comment 5 • 22 years ago

checked in trunk

	Pete Zha Reporter
	Comment 6 • 22 years ago

checked in NETSCAPE_7_0_OEM_BRANCH (a=jdunn)

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 7 • 22 years ago

This caused a fairly serious regression in bug 163800.

You can't just skip the AttributeChanged logic if there are no scrollbars. The
problem is that if the content shrinks so that the scrollbars are not needed and
disappear, the AttributeChanged logic is required to scroll what's left of the
document back into view. Otherwise we can be left looking below the bottom of
the document with no way to scroll back up!

Please find out why this crashes print preview and fix that rather than whacking
layout here.

	Andrew Schultz
	Comment 8 • 22 years ago

> This caused a fairly serious regression in...

bug 168170

	Pete Zha Reporter
	Comment 9 • 22 years ago

ok, let's investigate it.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 10 • 22 years ago

I think we should start by backing out the first part of the patch on the trunk,
to undo the regression.

	Pete Zha Reporter
	Comment 11 • 22 years ago

backout first part of previou patch to resolve the layout regression.

	rods (gone)
	Comment 12 • 22 years ago

Comment on attachment 100360 [details] [diff] [review]
patch to backout

r=rods

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 13 • 22 years ago

Comment on attachment 100360 [details] [diff] [review]
patch to backout

sr=roc+moz

	Pete Zha Reporter
	Comment 14 • 22 years ago

Comment on attachment 100360 [details] [diff] [review]
patch to backout

checked in this backout patch

	Pete Zha Reporter
	Comment 15 • 22 years ago

see also bug 135653

	Olivier Cahagne
	Comment 16 • 22 years ago

shall we close this one ? Every bug depending on this one seem to have been fixed.

	Pete Zha Reporter
	Comment 17 • 22 years ago

sure, already checked in on comment 14

	Pete Zha Reporter
	Comment 18 • 22 years ago

oh, sorry, I should not close this bug! on comments 14, I just checked in the
backout patch. We should test if the orignial problem still exists.
->REOPEN

	Bill Mason
	Comment 19 • 22 years ago

The testcase WFM in 2003040105 PC/WinXP.  Probably this issue has resolved itself.

A similiar crash with fixed DIVs is occurring in bug 200774, FWIW.

	Laurin Rötzer
	Comment 20 • 21 years ago

Still/again there in 1.6final?
Try it at www.winfuture.de.
But at pages like this, it works well.

	James Napolitano
	Comment 21 • 21 years ago

In Mozilla 1.7RC2 on Win98se, both the testcase and http://www.winfuture.de/ do
not crash for me on print preview.  Is this bug still present?

	Laurin Rötzer
	Comment 22 • 21 years ago

http://www.winfuture.de still crashes with 1.7RC2 (clean install on WinXP)

	Martijn Wargers (dead)
	Comment 23 • 20 years ago

Is this bug still present in builds at/after 2005-03-23?

	Wayne Mery (:wsmwk)
	Comment 24 • 19 years ago

WFM no crash with testcase or http://www.winfuture.de/

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20050907 Firefox/1.6a1
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051020 SeaMonkey/1.1a

and also on XP - recent trunk builds but not same as above

	Wayne Mery (:wsmwk)
	Comment 25 • 19 years ago

-> WFM