Closed Bug 1638011 Opened 4 years ago Closed 4 years ago

Block WebRender in release on > 60Hz monitors

Categories

(Core :: Graphics: WebRender, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox77 --- fixed
firefox78 --- fixed

People

(Reporter: jrmuizel, Assigned: aosmond)

References

Details

Attachments

(1 file)

We want to improve things more before we can do this well.

Andrew can you look at doing this?

Flags: needinfo?(aosmond)
Blocks: 1636604
Priority: -- → P2
Severity: -- → N/A
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Flags: needinfo?(aosmond)
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e1c031719669 Block WebRender in release for high refresh rate monitors. r=jrmuizel

Need to refresh uplift to beta once this makes its way into nightly.

Flags: needinfo?(aosmond)

Why does win32 use a different calling convention..... today I learned. Waiting try build to come back green for target.

Flags: needinfo?(aosmond)
Flags: needinfo?(aosmond)
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47219a623fca Block WebRender in release for high refresh rate monitors. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78

Comment on attachment 9149220 [details]
Bug 1638011 - Block WebRender in release for high refresh rate monitors.

Beta/Release Uplift Approval Request

  • User impact if declined: WebRender may not work as well at higher refresh rates. This change mitigates that risk.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very low, in the worst case WebRender would just be turned off in the wrong places.
  • String changes made/needed:
Attachment #9149220 - Flags: approval-mozilla-beta?

Comment on attachment 9149220 [details]
Bug 1638011 - Block WebRender in release for high refresh rate monitors.

Low risk mitigation, uplift approved for beta before RC, thanks.

Attachment #9149220 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(aosmond)
Regressions: 1641510
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: