Closed
Bug 1638211
Opened 5 years ago
Closed 5 years ago
In RFP mode, kkapsner's Canvas test leads to a tab crash
Categories
(Core :: Security, defect)
Tracking
()
VERIFIED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox76 | --- | unaffected |
| firefox77 | --- | unaffected |
| firefox78 | --- | verified |
People
(Reporter: me, Assigned: me)
References
(Regression)
Details
(Keywords: regression)
Crash Data
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Someone pointed out to me that in today's nightly, one can cause a tab crash by visiting kkapsner's Canvas test page.
steps to reproduce:
- Set privacy.resistFingerprinting = true
- Visit https://canvasblocker.kkapsner.de/test/test.html
actual result: tab crash
expected result: no tab crash
They also added that this might be a regression from Bug 1621433.
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
The bug
Assertion failure: IsAtomic<bool>::value || NS_IsMainThread() (Non-atomic static pref 'privacy.resistFingerprinting.randomDataOnCanvasExtract' being accessed on background thread by getter), at /home/sanketh/Projects/obj-mc/dist/include/mozilla/StaticPrefList_privacy.h:162
The fix should be a one-liner, I'll get something up by tomorrow morning.
privacy.resistFingerprinting.randomDataOnCanvasExtract can be accessed by
background threads so it needs to be atomic.
Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/354180dbb211
Make privacy.resistFingerprinting.randomDataOnCanvasExtract a RelaxedAtomicBool r=tjr
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
|
||
Updated•5 years ago
|
Keywords: regression
|
|
||
Updated•5 years ago
|
Crash Signature: [@ mozilla::dom::GeneratePlaceholderCanvasData]
|
||
Updated•5 years ago
|
status-firefox-esr68:
--- → unaffected
|
||
Updated•4 years ago
|
Flags: qe-verify+
|
||
Comment 6•4 years ago
|
||
Confirmed issue over pages with 78.0a1 (2020-05-14) on macOS 10.15.5.
Fix verified with 78.0b7 on macOS 10.15.5, Ubuntu 18, Windows 10; and today's nightly for sanity.
Status: RESOLVED → VERIFIED
|
|
||
Updated•4 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•