Closed Bug 1638277 Opened 5 years ago Closed 4 years ago

about:processes should use s for the time unit of times taking more than 1000ms

Categories

(Toolkit :: Performance Monitoring, task, P2)

Product:
Toolkit
Component:
Performance Monitoring
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1635117
Project Flags:
Fission Milestone M7

People

(Reporter: florian, Assigned: Yoric)

References

Details

(Whiteboard: [lang=js])

about:performance currently displays time in ms, but the values often grow much bigger than 1000ms, and in that case displaying in s would be better. And for long sessions, minutes and hours would be nice too.

Summary: about:performance should use s for the time unit of times taking more than 1000ms → about:processes should use s for the time unit of times taking more than 1000ms

If someone is interested in picking this bug, the code lives in aboutProcesses.js. We currently always display the number of ms (milliseconds). We should be a bit smarter about this:

  • if data.totalCpuUser <= 1 second, we should display it as milliseconds, as we do now;
  • otherwise, if data.totalCpuUser <= 120 seconds, we should display it as seconds;
  • otherwise, if data.totalCpuUser <= 2h, we should display it as minutes;
  • otherwise, if data.totalCpuUser <= 2 days, we should display it as hours;
  • otherwise, display it as days.
Mentor: dteller
Whiteboard: [lang=js]

Can I take this?

It will be a nice improvement to the Performance Monitoring!

Hey yoric, as per this bug, shouldn't we implement this feature in cpu ?

(In reply to Sonia from comment #4)

Hey yoric, as per this bug, shouldn't we implement this feature in cpu ?

What do you mean?

Flags: needinfo?(soniasingla.1812)
Flags: needinfo?(soniasingla.1812)

As per bug we have removed CPU USER and KERNEL and inserted a new column with CPU (USER+KERNEL)

Here, we are trying to use if else loop in the lines which is CPU USER

Note that the code has changed a lot since this bug was filed. You may need to rebase your patches.

Assignee: nobody → dteller
Mentor: dteller
Severity: -- → S3
Status: NEW → ASSIGNED
Fission Milestone: --- → M7
Priority: -- → P2

Fixed by bug 1635117.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.