Closed Bug 1638365 Opened 4 years ago Closed 4 years ago

Make browsertime initialize page loads through parent process with webdriver

Categories

(Testing :: Raptor, task, P2)

Version 3
task

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: sparky, Assigned: sparky)

References

Details

(Keywords: perf-alert)

Attachments

(2 files)

Currently, browsertime triggers pageloads through the content process by using window.location for navigating, but this method misses many paths that the parent process takes resulting in less realistic performance results. This bug is for changing this method from window.location to webdriver.get. There is ongoing work in geckodriver to make this possible, and we will block on that.

The option --webdriverPageload will now do this, in conjunction with the change from Bug 1612831.

Attached image fennec_fenix_connectStart_boxplot.png (deleted) β€”

We can see how the window.location navigation was distorting Fenix first network request times.

This plot shows connectStart in both fennec and Fenix with the default (window.location) and also via the webdriver load (which goes through the parent process).

This patch upgrade browsertime to v10, enables webdriver-based navigation in browsertime tests, and also disables the Firefox WindowRecorder for a fairer comparison between Chrome and Firefox.

Assignee: nobody → gmierz2
Status: NEW → ASSIGNED
Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/2052e35c9932
Use webdriver navigation for pageload tests. r=perftest-reviewers,Bebe

We may see the difference highlighted in the lives site CI tests, will be interesting.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Backed out changeset 2052e35c9932 (Bug 1638365) for performance regressions as requested by alexandrui on irc.
https://hg.mozilla.org/integration/autoland/rev/71303e2307a3abae2701f7a63d69914d65cf85c4

Status: RESOLVED → REOPENED
Flags: needinfo?(gmierz2)
Resolution: FIXED → ---
Target Milestone: 84 Branch → ---

(In reply to Cristian Brindusan [:cbrindusan] from comment #7)

Backed out changeset 2052e35c9932 (Bug 1638365) for performance regressions as requested by alexandrui on irc.
https://hg.mozilla.org/integration/autoland/rev/71303e2307a3abae2701f7a63d69914d65cf85c4

== Change summary for alert #27613 (as of Thu, 12 Nov 2020 12:48:40 GMT) ==

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
60% allrecipes fcp android-hw-p2-8-0-android-aarch64-shippable warm 198.06 -> 315.96
34% allrecipes ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable warm 454.17 -> 607.67
8% allrecipes loadtime android-hw-g5-7-0-arm7-api-16-shippable warm webrender 4,006.52 -> 4,318.54
6% ebay-kleinanzeigen-search PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable warm webrender 713.73 -> 757.75
6% ebay-kleinanzeigen PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable warm webrender 576.90 -> 611.42

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27613

Flags: needinfo?(gmierz2)
Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/741ea917c5e8
Use webdriver navigation for pageload tests. r=perftest-reviewers,Bebe,AlexandruIonescu
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Regressions: 1680727
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: