Closed Bug 1638914 Opened 4 years ago Closed 4 years ago

"watchedByDevTools can only be set on top BrowsingContext" exception when opening the MBT with fission enabled

Categories

(DevTools :: Framework, defect)

defect

Tracking

(Fission Milestone:M6c, firefox-esr68 unaffected, firefox76 unaffected, firefox77 unaffected, firefox78 wontfix, firefox79 fixed)

RESOLVED FIXED
Firefox 79
Fission Milestone M6c
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- unaffected
firefox77 --- unaffected
firefox78 --- wontfix
firefox79 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

This comes from this line:
https://searchfox.org/mozilla-central/rev/9193635dca8cfdcb68f114306194ffc860456044/devtools/server/actors/targets/browsing-context.js#1618
When we spawn targets for remoted iframes in a tab.
In order to reproduce, you would need a page with an iframe using an origin different from the top level tab document.

In this particular case, the watchedByDevTools attribute is already toggled by the top level target, so there is no need to toggle it again in additional targets.
This attribute may later be set by the TabDescriptor or Watcher actor only once, on the top level target BrowsingContext.
See:
https://phabricator.services.mozilla.com/D65983

Set release status flags based on info from the regressing bug 1620966

Tracking DevTools Fission bugs for Fission Nightly milestone (M6c).

Fission Milestone: --- → M6c

The severity field is not set for this bug.
:ochameau, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(poirot.alex)
Severity: -- → S3
Flags: needinfo?(poirot.alex)

This attribute can only be toggled on top level BrowsingContext.
These are the top level window's, or tab's BrowsingContext.
From DevTools point of view, it should only be toggled by the
Parent Process or Tab target.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3c129f197ec Fix watchedByDevTools exceptions when debugging with Fission ON. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: