Closed Bug 1639516 Opened 5 years ago Closed 5 years ago

Broken build if MOZ_GECKO_PROFILER is not defined

Categories

(Core :: IPC, defect)

All
Linux
defect

Tracking

()

RESOLVED DUPLICATE of bug 1638293
Tracking Status
firefox78 --- fixed

People

(Reporter: msirringhaus, Unassigned)

Details

In ipc/glue/GeckoChildProcessHost.cpp, Line 1028, function bool BaseProcessLauncher::DoSetup() the local variable self is only defined if MOZ_GECKO_PROFILER is defined. (see https://searchfox.org/mozilla-central/source/ipc/glue/GeckoChildProcessHost.cpp#1030)
But it is used later in the function, even if MOZ_GECKO_PROFILER is not defined, leading to a broken build.

The line RefPtr<BaseProcessLauncher> self = this; probably only needs to be moved up by one line, out of the ifdef-guard.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.