Closed Bug 1639548 Opened 5 years ago Closed 2 years ago

Purge private browsing mode storage on private browsing mode session end

Categories

(Core :: Storage: Quota Manager, task, P3)

Product:
Core
Component:
Storage: Quota Manager
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: sg, Assigned: janv)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Bug 1639548 - Purge private browsing mode storage on private browsing mode session end. r=#dom-workers-and-storage
(deleted), text/x-phabricator-request
Details
Bug 1639548 - Remove redundant purging of localstorage private mode data. r=#dom-workers-and-storage,janv
(deleted), text/x-phabricator-request
Details
Bug 1639548 - Move IndexedDBCipherKeyManager to DatabaseFileManager; r=#dom-storage
(deleted), text/x-phabricator-request
Details

Note from asuth:

A purge needs to be added for shutdown and the private browsing last window closed for the OriginAttribute variant.

Priority: -- → P3
Assignee: nobody → sgiesecke
Attachment #9169177 - Attachment description: Bug 1639548 - Purge private browsing mode IndexedDB storage on private browsing mode session end. r=dom-workers-and-storage,janv → Bug 1639548 - Purge private browsing mode storage on private browsing mode session end. r=#dom-workers-and-storage,janv

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: simon.giesecke → nobody
Component: Storage: IndexedDB → Storage: Quota Manager
Summary: Purge private browsing mode IndexedDB storage on private browsing mode session end → Purge private browsing mode storage on private browsing mode session end
Depends on: 1791675
Assignee: nobody → jvarga
Attachment #9169177 - Attachment description: Bug 1639548 - Purge private browsing mode storage on private browsing mode session end. r=#dom-workers-and-storage,janv → WIP: Bug 1639548 - Purge private browsing mode storage on private browsing mode session end. r=#dom-workers-and-storage
Status: NEW → ASSIGNED
Attachment #9304622 - Attachment is obsolete: true
Attachment #9169177 - Attachment description: WIP: Bug 1639548 - Purge private browsing mode storage on private browsing mode session end. r=#dom-workers-and-storage → Bug 1639548 - Purge private browsing mode storage on private browsing mode session end. r=#dom-workers-and-storage
Pushed by hsingh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d75a6ebb97d3 Purge private browsing mode storage on private browsing mode session end. r=dom-workers-and-storage-reviewers,janv DONTBUILD
Pushed by hsingh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3251a6ea2ed Remove redundant purging of localstorage private mode data. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/2da5597a6ab0 Move IndexedDBCipherKeyManager to DatabaseFileManager; r=hsingh

Backed out 5 changesets (Bug 1639545, Bug 1639548, Bug 1818214) for multiple mochitest dom/indexedDB/test/... related test failures.
Backout link
Push with failures <--> 2
Failure Log
Fixed by commit filter

Flags: needinfo?(jvarga)
Flags: needinfo?(jvarga) → needinfo?(hsingh)

Backed out changeset d75a6ebb97d3 (Bug 1639548) for high freq marionette failures on test_IDB_encryption_PBM.py.
Backout link
Push with failures <--> Mn
Failure Log

This also fixes the reappearance of the Bb bustage after the fix was also backed out.

Flags: needinfo?(jvarga)
Pushed by hsingh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0472cc860cab Purge private browsing mode storage on private browsing mode session end. r=janv https://hg.mozilla.org/integration/autoland/rev/00764be394ec Remove redundant purging of localstorage private mode data. r=janv https://hg.mozilla.org/integration/autoland/rev/f13ecef45c88 Move IndexedDBCipherKeyManager to DatabaseFileManager; r=hsingh

https://hg.mozilla.org/mozilla-central/rev/0472cc860cab
https://hg.mozilla.org/mozilla-central/rev/00764be394ec
https://hg.mozilla.org/mozilla-central/rev/f13ecef45c88

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Flags: needinfo?(hsingh)

The backout and relanding addressed by Harveer IIRC.

Flags: needinfo?(jvarga)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: