Closed
Bug 164003
Opened 22 years ago
Closed 22 years ago
Button "Add another boolean chart" appears twice after clicking "And"
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: robert.pollak, Assigned: gerv)
References
Details
(Keywords: polish, regression)
Attachments
(1 file)
(deleted),
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
Observed at http://bugzilla.mozilla.org/query.cgi :
After entering an "Advanced Query" term and clicking "And", the query page gets
two "Add another boolean chart" buttons.
Expected behavior:
Button only appears once. See e.g. the following installation of Bugzilla 2.14.1
for the correct behavior: http://itos.gsfc.nasa.gov/~bugzilla/query.cgi
Reporter | ||
Updated•22 years ago
|
Keywords: regression
Comment 1•22 years ago
|
||
This is just cosmetic, and I'm not sure if it was done on purpose. gerv?
Assignee: endico → gerv
Keywords: polish
Assignee | ||
Comment 2•22 years ago
|
||
Even though it's cosmetic, I'd probably call that a bug :-) It should only
appear at the bottom.
Gerv
Assignee | ||
Comment 3•22 years ago
|
||
This should do the trick.
Gerv
Comment 4•22 years ago
|
||
Also happens with [Or] button.
I found this regression independently when trying to apply my patch for bug
92253. My latest patch on that bug also contains a (slightly different) fix for
this bug.
Blocks: 92253
Version: 2.17 → 2.16
Comment 5•22 years ago
|
||
Comment on attachment 104415 [details] [diff] [review]
Patch v.1
r=myk
Attachment #104415 -
Flags: review+
Assignee | ||
Comment 6•22 years ago
|
||
Dave: can I get a=, please? :-)
Gerv
Comment 7•22 years ago
|
||
a= justdave
Assignee | ||
Comment 8•22 years ago
|
||
Fixed.
Checking in template/en/default/search/boolean-charts.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/boolean-charts.html.tmpl,v
<-- boolean-charts.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Gerv
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•