Closed Bug 1640103 Opened 4 years ago Closed 4 years ago

2.2 - 57.88% Explicit Memory / Heap Unclassified / Resident Memory (linux1804-64-shippable-qr, windows10-64-shippable-qr) regression on push a9eaeeec414894e9968976cdf58ae390d0244970 (Tue May 19 2020)

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- unaffected
firefox77 --- unaffected
firefox78 --- fixed

People

(Reporter: Bebe, Assigned: nical)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Attachments

(2 files)

Perfherder has detected a awsy performance regression from push a9eaeeec414894e9968976cdf58ae390d0244970. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

58% Heap Unclassified windows10-64-shippable-qr opt 58,994,483.18 -> 93,140,779.81
11% Explicit Memory windows10-64-shippable-qr opt 377,595,830.07 -> 419,282,607.74
6% Resident Memory windows10-64-shippable-qr opt 582,564,360.58 -> 618,457,984.87
6% Heap Unclassified linux1804-64-shippable-qr opt 251,194,917.01 -> 266,208,212.44
5% Heap Unclassified windows10-64-shippable-qr opt tp6 72,599,238.13 -> 76,463,156.68
3% Explicit Memory linux1804-64-shippable-qr opt 571,056,299.73 -> 590,373,183.88
2% Resident Memory linux1804-64-shippable-qr opt 895,175,589.84 -> 914,912,469.46

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Component: Performance → Graphics: WebRender
Flags: needinfo?(nical.bugzilla)
Product: Testing → Core

I think that this is caused by not calling BlobImageHandler::clear_namespace anymore when destroying the API object. I'll put something together to make sure it is called.

Flags: needinfo?(nical.bugzilla)
Assignee: nobody → nical.bugzilla

This should fix a memory usage regression from https://hg.mozilla.org/integration/autoland/rev/a9eaeeec414894e9968976cdf58ae390d0244970 which I suspect was caused by not clearing the blob's namespace anymore after destroying the api object.

Depends on D76489

Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d7a8b81ee0c Call clear_namespace on the blob image handler. r=gw
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: