Disabling JavaScript still applies to all tabs after DevTools close
Categories
(DevTools :: Debugger, defect, P2)
Tracking
(firefox-esr68 unaffected, firefox76 unaffected, firefox77 wontfix, firefox78 fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox76 | --- | unaffected |
| firefox77 | --- | wontfix |
| firefox78 | --- | fixed |
People
(Reporter: Harald, Assigned: davidwalsh)
References
(Regression)
Details
(Keywords: dev-doc-complete, regression)
Attachments
(1 file)
|
Bug 1640318 - Disable only JavaScript in the present tab when using the debugger menu r=jlast,Harald
(deleted),
text/x-phabricator-request
|
Details |
What were you doing?
- Open DevTools on Debugger
- Check Disable JavaScript in the settings menu.
- Close DevTools
What happened?
JS doesn't work in any tab. Debugger has to be opened again and the option unchecked.
What should have happened?
Disabling JS only affects the current tab and is reset when DevTools closes, similar to Disable Cache.
Anything else we should know?
This can be a massive footgun for developers. I marked this regression as the option is much easier to find now and can surprise more developers.
The root cause is that the new Debugger settings menu does toggle the global javascript.enabled setting. The existing Disable JavaScript in Settings sets a docShell specific flag which gets reset when DevTools closes (and also handles refresh on toggle).
|
Reporter | |
Comment 1•5 years ago
|
||
Honza, David, Jason, any ideas if this can be fixed in 78, maybe uplifted to 77?
|
Assignee | |
Comment 2•5 years ago
|
||
@honza @jlast Could you provide a bit of guidance to help me get this updated quickly? I've not worked with docShell before!
|
|
Reporter | |
Comment 3•5 years ago
|
||
Would the way the Settings panel calls reconfigure() it not also work for Debugger: https://searchfox.org/mozilla-central/rev/fc91a093e40dde71d10ad219946b8ae775aca9eb/devtools/client/framework/toolbox-options.js#615
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Comment 6•5 years ago
|
||
Set release status flags based on info from the regressing bug 1630957
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
|
|
||
Comment 9•4 years ago
|
||
Updated the UI Tour to reflect the corrected behavior.
|
||
Updated•4 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Description
•