Closed Bug 1640998 Opened 4 years ago Closed 4 years ago

Implement support actions API on MediaControlKeysEventSource

Categories

(Core :: Audio/Video: Playback, task, P1)

Product:
Core
Component:
Audio/Video: Playback
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: dev-doc-needed)

Attachments

(9 files)

Bug 1640998 - part1 : make `ContentMediaAgent` inherit from `IMediaInfoUpdater`.
(deleted), text/x-phabricator-request
Details
Bug 1640998 - part2 : use `ContentMediaAgent` to update media session's related information.
(deleted), text/x-phabricator-request
Details
Bug 1640998 - part3 : add methods to update supported action from media sessions.
(deleted), text/x-phabricator-request
Details
Bug 1640998 - part4 : update supported action changes from the content process.
(deleted), text/x-phabricator-request
Details
Bug 1640998 - part5 : set supported keys to the event source
(deleted), text/x-phabricator-request
Details
Bug 1640998 - part6 : only notify the active media session's metadata change.
(deleted), text/x-phabricator-request
Details
Bug 1640998 - part7 : create `MediaController` webidl.
(deleted), text/x-phabricator-request
Details
Bug 1640998 - part8 : add test.
(deleted), text/x-phabricator-request
Details
Bug 1640998 - part9 : use `MediaControlKey` to replace `MediaControlKeysEvent`
(deleted), text/x-phabricator-request
Details

Per [1], we would like to implement supported actions for MediaControlKeysEventSource.

[1] https://w3c.github.io/mediasession/#supported-media-session-actions

Finish the first version, then I'm going to write tests.

Today's update, finish the webidl for exposing the media controller to Chrome JS, which allows us to write test easier and can be used for the MediaHub.

Attached file Bug 1640998 - part8 : add test. (deleted) —

Because there are already too many patches on implementing supported action, I will move supporting PiP to another bug. In addition, will also file a bug for supporting controlling media before media starts, which is a request from Firefox Reality team.

Blocks: 1642711
Blocks: 1642715
Attachment #9152293 - Attachment description: Bug 1640998 - part5 : set displayable content to the event source. → Bug 1640998 - part5 : set supported keys to the event source

This patch will

  • remove MediaControlKeysEvent and use MediaControlKey to replace it
  • rename names for all MediaControlKey related methods, functions, classes and descriptions

The advantage of doing so are

  • remove the duplicated type so that we only need to maintain MediaControlKey
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a042c009ea63 part1 : make `ContentMediaAgent` inherit from `IMediaInfoUpdater`. r=chunmin https://hg.mozilla.org/integration/autoland/rev/753f1c632de5 part2 : use `ContentMediaAgent` to update media session's related information. r=chunmin https://hg.mozilla.org/integration/autoland/rev/3502f8c7a17d part3 : add methods to update supported action from media sessions. r=chunmin https://hg.mozilla.org/integration/autoland/rev/a48b6554ba9c part4 : update supported action changes from the content process. r=chunmin https://hg.mozilla.org/integration/autoland/rev/714b2fb21e23 part5 : set supported keys to the event source r=chunmin https://hg.mozilla.org/integration/autoland/rev/98843b4e9041 part6 : only notify the active media session's metadata change. r=chunmin https://hg.mozilla.org/integration/autoland/rev/8e04037ca021 part7 : create `MediaController` webidl. r=chunmin,smaug https://hg.mozilla.org/integration/autoland/rev/e41abab613ae part8 : add test. r=chunmin https://hg.mozilla.org/integration/autoland/rev/52e0f62534ea part9 : use `MediaControlKey` to replace `MediaControlKeysEvent` r=chunmin,agi,geckoview-reviewers
Regressions: 1644479
Regressions: 1645852
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: