Closed Bug 1641280 Opened 4 years ago Closed 3 years ago

Enable Web Share by default on Windows Nightly

Categories

(Core :: DOM: Core & HTML, task, P3)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
Windows 10
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

Bug 1641280 - Part 1: Fix lint warnings in WindowsUIUtils r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1641280 - Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=agashlin
(deleted), text/x-phabricator-request
Details
Bug 1641280 - Part 3: Enable Web Share on Windows for nightly/beta r=smaug
(deleted), text/x-phabricator-request
Details

The Windows May 2020 update is now generally available, which includes ShareCanceled API needed to track share cancellation.

Currently a caveat is that there is still no way to track selection of "Copy Link" feature, and doing so currently creates a promise that will never be resolved.

Severity: -- → N/A
Priority: -- → P3
Assignee: nobody → krosylight
Status: NEW → ASSIGNED

This feature has been deferred on Windows since Windows does not fire any DataPackage event when a user selects copy action from the OS dialog, potentially causing never-resolved promise. Windows still does not provide any other way to detect that action, even on Windows 11.

Per https://github.com/w3c/web-share/issues/188 Chromium gave up waiting user action and decided to immediately resolve the promise.

Given that Microsoft is not expected to fix the situation anytime soon, it's probably better to ship it in the form others have for feature parity.

Depends on D121420

Attachment #9234055 - Attachment description: Bug 1641280 - Part 2: Immediately resolve navigator.share on Windows r=smaug → Bug 1641280 - Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=agashlin
Attachment #9234178 - Attachment description: Bug 1641280 - Part 3: Enable Web Share on Windows r=smaug → Bug 1641280 - Part 3: Enable Web Share on Windows for nightly/beta r=smaug
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b183dae47176 Part 1: Fix lint warnings in WindowsUIUtils r=smaug https://hg.mozilla.org/integration/autoland/rev/080107249a1c Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=smaug,agashlin https://hg.mozilla.org/integration/autoland/rev/aa2915f66825 Part 3: Enable Web Share on Windows for nightly/beta r=smaug

Backed out 3 changesets (Bug 1641280) for causing bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/3a298e8456aec9771c496387811326d1a3e3d278
Push with failures, failure log.

Flags: needinfo?(krosylight)
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec4804b0afb3 Part 1: Fix lint warnings in WindowsUIUtils r=smaug https://hg.mozilla.org/integration/autoland/rev/026a1eb28a9a Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=smaug,agashlin https://hg.mozilla.org/integration/autoland/rev/4e731a3280df Part 3: Enable Web Share on Windows for nightly/beta r=smaug
Flags: needinfo?(krosylight)

https://hg.mozilla.org/mozilla-central/rev/ec4804b0afb3
https://hg.mozilla.org/mozilla-central/rev/026a1eb28a9a
https://hg.mozilla.org/mozilla-central/rev/4e731a3280df

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Keywords: dev-doc-needed → dev-doc-complete
Regressions: 1737541
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: