Pinch-to-zoom doesn't zoom on second screen of a hybrid setup.
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: mhoye, Assigned: tnikkel)
References
Details
Attachments
(2 files)
I've got a multimonitor setup, and when Firefox is on my touch-enabled screen, both the trackpad pinch and screen pinch work as expected, but when I put Firefox on the other non-touch-enabled monitor, screen pinch obviously doesn't work, but trackpad pinch also doesn't work.
My setup is, Surface Book 2 with precision trackpad and touchscreen, external monitor without touch capability, Win10 current as of today, Nightly same.
apz.windows.use_direct_manipulation and apz.allow_zooming are both set to true, and pinch to zoom works correctly, screen and touchpad, when Firefox is on the touch-enabled screen.
|
Reporter | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 1•4 years ago
|
||
Does it work in Chrome? Or Edge? Either Chromium based Edge or otherwise.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Also, does it work if the Firefox window is never on the touch screen? ie it starts it's life on the external monitor and is never moved.
|
|
Assignee | |
Comment 3•4 years ago
|
||
I realized that my old Surface Pro 2 had a mini display port so I could use my tv as a external monitor and then hack the source to enable direct manipulation on windows 8 to reproduce this.
|
|
Assignee | |
Comment 4•4 years ago
|
||
The problem is the mFocusPoint is in screen coords and should be relative to the widget. I was thrown off by this comment
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac8ebdcda25b Put the focus point of pinch events from Direct Manipulation in widget relative coordinates. r=kats
|
||
Comment 7•4 years ago
|
||
Backed out changeset ac8ebdcda25b for causing bustages in DirectManipulationOwner.
Backout link: https://hg.mozilla.org/integration/autoland/rev/4aaf11a81c97be66d2eb9498a2b08ccb33d19cad
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=ac8ebdcda25ba6f6bbc62c27dffc63c1e4219a12
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304375032&repo=autoland&lineNumber=29584
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65c72f5bd06f Put the focus point of pinch events from Direct Manipulation in widget relative coordinates. r=kats
|
|
Assignee | |
Comment 9•4 years ago
|
||
Depends on D77576
|
||
Comment 10•4 years ago
|
||
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b5a14110749 Small follow up.
|
|
Assignee | |
Comment 11•4 years ago
|
||
Thanks for testing and filing. Let us know if you see any more problems.
|
||
Comment 12•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/65c72f5bd06f
https://hg.mozilla.org/mozilla-central/rev/6b5a14110749
Description
•