Closed Bug 1642344 Opened 4 years ago Closed 4 years ago

Convert all the VarCache prefs in dom/*

Categories

(Core :: DOM: Core & HTML, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: Gankra, Assigned: Gankra)

References

Details

Attachments

(6 files, 1 obsolete file)

Specifically these preferences:

dom.storage.next_gen

dom.max_script_run_time
dom.max_chrome_script_run_time

converter.html2txt.always_include_ruby

plugin.mousewheel.enabled
mousewheel.autodir.enabled
mousewheel.autodir.honourroot
accessibility.accesskeycausesactivation
ui.click_hold_context_menus

dom.experimental_forms
dom.forms.datetime.others
dom.forms.color

dom.noopener.newprocess.enabled

dom.testing.ignore_ipc_principal
Assignee: nobody → a.beingessner

DOM: Core isn't quite right, but it feels closer to the right component than General, given that these prefs are all under dom/.

Component: General → DOM: Core & HTML
Severity: -- → N/A
Priority: -- → P2

NOTE: this also removes a mysterious old comment that implied this code could run without libpref initializing
the value, in which case they picked a different default. I assume this is no longer a real configuration?

Depends on D77847

converts:

  • plugin.mousewheel.enabled
  • mousewheel.autodir.enabled
  • mousewheel.autodir.honourroot
  • accessibility.accesskeycausesactivation
  • ui.click_hold_context_menus

Depends on D77848

converts:

  • dom.experimental_forms
  • dom.forms.datetime.others
  • dom.forms.color

Depends on D77849

This review comment raises an interesting question about the next_storage pref, and how pref initialization works, that I need to investigate further. I suggest we land the other patches in the interim, to avoid bitrot.

Pushed by abeingessner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d804de3225b0 Remove unused field from JSSettings and flatten away a struct. r=baku https://hg.mozilla.org/integration/autoland/rev/c02b43c5cf49 convert converter.html2txt.always_include_ruby into a StaticPref. r=KrisWright https://hg.mozilla.org/integration/autoland/rev/5b40ba91c89a convert EventStateManager VarCache prefs to StaticPrefs. r=KrisWright,masayuki https://hg.mozilla.org/integration/autoland/rev/cd600940f441 convert HTMLInputElement VarCache prefs to StaticPrefs. r=geckoview-reviewers,agi. https://hg.mozilla.org/integration/autoland/rev/191e6bda6d77 convert dom.noopener.newprocess.enabled to a StaticPref. r=KrisWright https://hg.mozilla.org/integration/autoland/rev/6943a06706ca remove unused dom.testing.ignore_ipc_principal pref. r=KrisWright
Attachment #9153486 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: