Closed Bug 1642364 Opened 4 years ago Closed 4 years ago

Add a temporary solution for modal dialog centered alignment

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: sefeng, Assigned: sefeng)

References

Details

Attachments

(1 file)

The patch we did in bug 1637310 was hacky and we were not happy with the solution. There will be discussion in CSS workgroup to talk about better solutions.

In the meantime, we can add a temporary solution for it to allow us to enable it in Nightly for dogfooding.

Spec: https://html.spec.whatwg.org/multipage/#centered-alignment

The spec is opaque about the centered alignment mode and we couldn't
come up a satisfied solution by using the current version of the
spec. There will be discussion in CSSWG to talk about better solutions.
In the meantime, we are adding this patch as a temporary solution with
basic centered alignment support to allow us enabling the feature
in Nightly for more testing.

Severity: -- → N/A
Priority: -- → P2
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3799309b95c Add a temporary solution for modal dialog centered alignment r=emilio
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d06403ffd5c Add a temporary solution for modal dialog centered alignment r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23961 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR was closed without merging
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/979a3003f357 Add a temporary solution for modal dialog centered alignment r=emilio
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Upstream PR merged by moz-wptsync-bot
Flags: needinfo?(sefeng)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: