Closed Bug 1642770 Opened 5 years ago Closed 2 years ago

Investigate Puppeteer 3 regression in pressing meta key

Categories

(Remote Protocol :: CDP, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: impossibus, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

This starting failing since we updated from v2.1.0 to v3.1.0 of Puppeteer in Bug 1632710

itFailsFirefox('should press the meta key', async () => {
    const { page, isFirefox } = getTestState();

    await page.evaluate(() => {
      window.result = null;
      document.addEventListener('keydown', (event) => {
        window.result = [event.key, event.code, event.metaKey];
      });
    });
    await page.keyboard.press('Meta');
    const [key, code, metaKey] = await page.evaluate('result');
    if (isFirefox && os.platform() !== 'darwin') expect(key).toBe('OS');
    else expect(key).toBe('Meta');

    if (isFirefox) expect(code).toBe('OSLeft');
    else expect(code).toBe('MetaLeft');

    if (isFirefox && os.platform() !== 'darwin') expect(metaKey).toBe(false);
    else expect(metaKey).toBe(true);
  });
Regressed by: 1632710
Summary: Investigate regression in pressing meta key → Investigate Puppeteer 3 regression in pressing meta key
Severity: -- → S3
Component: CDP: Input → CDP

I don't think it makes sense to spend time on that regression anymore for CDP. Now that Puppeteer is transitioning over to WebDriver BiDi we can make sure that meta key handling is properly supported.

Status: NEW → RESOLVED
Closed: 2 years ago
Keywords: regression
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.