Style editor and debugger should always get generated url/line/column for view-source requests
Categories
(DevTools :: Debugger, defect)
Tracking
(firefox79 fixed)
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: loganfsmyth, Assigned: loganfsmyth)
References
(Blocks 1 open bug)
Details
Attachments
(7 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
Bug 1643180 - Part 4: Centralize viewSourceInDebugger's source ID and sourcemap processing. r=jlast!
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
The toolbox exposes toolbox.viewSourceInDebugger and toolbox.viewSourceInStyleEditor functions for navigating from other panels to the debugger or style editor.
Right now thes are passed a mishmash of original or generated url/line/column triple, sometimes with an actor ID instead of a URL, depending on whether the sourcemap url service has had time to load the sourcemap, among other things.
The other piece of is is that these functions themselves resolve positions to original positions if possible, which means that at the moment the style editor actually has no way to know what actor the request came from, just the URL, so things can still go wrong if multiple files share the same URL. This is also an issue for the debugger, because a generated file may share a URL with an original file, or there may be multiple original files with the same URL so even though we resolved the location using a source actor ID, we loose specificity if the position is mapped.
https://bugzilla.mozilla.org/show_bug.cgi?id=1642371 is doing a bit of the infrastructure work on this that mostly helps for CSS between other panels and the toolbox, but from the toolbox to the style editor itself can still lose information.
This bug should fully qualify everything so that if the toolbox is given a front or an actor ID, we are guaranteed to open exactly the right file in the style editor/debugger.
After that I can start on https://bugzilla.mozilla.org/show_bug.cgi?id=1641121 properly and then we should be as close to exact navigation as we'll be able to get.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D78380
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D78381
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D78382
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D78383
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D78384
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D78386
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ebafb2a3c1e5
https://hg.mozilla.org/mozilla-central/rev/f4137ceb9821
https://hg.mozilla.org/mozilla-central/rev/5a023712b666
https://hg.mozilla.org/mozilla-central/rev/b9f2a9fc40b6
https://hg.mozilla.org/mozilla-central/rev/ca592926cbb5
https://hg.mozilla.org/mozilla-central/rev/e3e927efe0d0
https://hg.mozilla.org/mozilla-central/rev/f5f4f276e171
Description
•