Closed
Bug 1643350
Opened 4 years ago
Closed 4 years ago
MComputeThis should return an object instead of Value
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
Warp MIR uses this instruction a lot, often followed by a fallible unbox. With some refactoring to our VM code we can make this return an object and eliminate the extra unbox.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
This comment is more confusing than helpful. SynthesizeFrame was a TraceMonkey thing.
Depends on D78296
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D78297
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D78298
|
|
Assignee | |
Comment 5•4 years ago
|
||
This is clearer because it calls js::BoxNonStrictThis.
Depends on D78299
|
||
Updated•4 years ago
|
Severity: normal → N/A
Priority: -- → P1
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3574210aae9c
part 1 - Rename GetThisValue{OfWith} to GetThisObject{OfWith} and return an object instead of Value. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f84d40e4bd62
part 2 - Remove an outdated comment. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/994f0c72f597
part 3 - Change LexicalEnvironmentObject's thisValue to thisObject. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/598c7c704811
part 4 - Make BoxNonStrictThis return an object instead of Value. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/248cdbaf2746
part 5 - Rename MComputeThis to MBoxNonStrictThis. r=tcampbell
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3574210aae9c
https://hg.mozilla.org/mozilla-central/rev/f84d40e4bd62
https://hg.mozilla.org/mozilla-central/rev/994f0c72f597
https://hg.mozilla.org/mozilla-central/rev/598c7c704811
https://hg.mozilla.org/mozilla-central/rev/248cdbaf2746
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in
before you can comment on or make changes to this bug.
Description
•