Closed Bug 1643402 Opened 4 years ago Closed 4 years ago

Collect telemetry on all PDF errors that can trigger PDF viewer fallback bar

Categories

(Firefox :: PDF Viewer, task)

task

Tracking

()

RESOLVED FIXED
Firefox 79
Tracking Status
firefox79 --- fixed

People

(Reporter: emmamalysz, Assigned: emmamalysz)

References

Details

Attachments

(2 files)

After Bug 1630844, we understand the error that is responsible for showing the fallback bar. However, we noticed that multiple errors may trigger the fallback bar and only the first is displayed. See https://www.irs.gov/pub/irs-pdf/f1040.pdf

We need to better understand all errors that can cause the fallback bar to trigger. We need to add a new telemetry probe to track the total distribution of errors.

Assignee: nobody → emalysz
Attached file Data Review Form (deleted) —
Attachment #9155148 - Flags: data-review?(chutten)
Status: NEW → ASSIGNED
Comment on attachment 9155148 [details] Data Review Form DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? No. This collection will expire in Firefox 84. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for all channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? Yes. :emalysz is responsible for renewing or removing the collection before it expires in Firefox 84. --- Result: datareview+
Attachment #9155148 - Flags: data-review?(chutten) → data-review+

Tried to land this but received:
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

applying /tmp/tmpyPzZHD
browser/extensions/pdfjs/content/PdfStreamConverter.jsm
Hunk #3 FAILED at 504.
1 out of 3 hunks FAILED -- saving rejects to file browser/extensions/pdfjs/content/PdfStreamConverter.jsm.rej
abort: patch command failed: exited with status 256

Flags: needinfo?(emalysz)
Flags: needinfo?(emalysz)
Pushed by nerli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/16f049638db0 add telemetry probe that collects information on all pdf fallback errors. r=bdahl
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: