Browser Console slows down main thread with `getRepeatId`
Categories
(DevTools :: Console, defect, P2)
Tracking
(firefox99 fixed)
Tracking | Status | |
---|---|---|
firefox99 | --- | fixed |
People
(Reporter: Harald, Assigned: nchevobbe)
References
(Blocks 2 open bugs)
Details
(Whiteboard: dt-console-perf-2022)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
+++ This bug was initially created as a clone of Bug #1643796 +++
I had Browser Console and Google Docs became extremely sluggish.
https://share.firefox.dev/2XFXeoV
getRepeatId
is 20% of the sample, just generating keys using JSON.
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Getting rid of the repeatId
property and turning it into a function for checking if 2 messages are similar, instead of stringifying an object as we do now.
From profiling, this seems to reduce time spent for this in comparison to getRepeatId
, but it doesn't really shows in DAMP: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=64beeeccfb8900057dbd2d8ba35596451340ab8b&newProject=try&newRevision=747060063e6d8c4a25dad7d28cf83ea3a0661bf0&framework=12&page=1
Assignee | ||
Comment 2•3 years ago
|
||
Adding 10 000 messages, 5 times (so a total of 50 000 messages), to try to get some median number.
with my patch: https://share.firefox.dev/34BpyOP
without: https://share.firefox.dev/3sklM4E
so that's a 25% improvement, nice but not great
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)
Adding 10 000 messages, 5 times (so a total of 50 000 messages), to try to get some median number.
with my patch: https://share.firefox.dev/34BpyOP
without: https://share.firefox.dev/3sklM4Eso that's a 25% improvement, nice but not great
So, I think my earliest patch wasn't optimal and was calling areMessagesSimilar
too much.
In a new version of the patch, I'm seeing 10x better performance. I'll push that to review soon
Assignee | ||
Comment 4•3 years ago
|
||
Comment 6•3 years ago
|
||
bugherder |
Description
•