Add a SCHEDULES rule to avoid running Android on changes exclusively to /browser
Categories
(Firefox Build System :: Task Configuration, enhancement, P2)
Tracking
(firefox79 fixed)
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Conversely, changes exclusive to /mobile
shouldn't run desktop platforms.
Assignee | ||
Updated•4 years ago
|
Comment 1•4 years ago
|
||
Do the SCHEDULES
changes distinguish between test changes and code changes? Asking because e.g. this push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fd91f0ec82be1e678ed58bfd16265a5b92055c5
is running android tests, though I'm not modifying any android code. But I modified toolkit/components/extensions/test/browser/browser_ext_themes_arrowpanels.js
which is a toolkit file - but a browser test, so still will only affect desktop.
Assignee | ||
Comment 2•4 years ago
|
||
The SCHEDULES
rules depend on what metadata you apply to specific source files, it's all manual. So you can make a SCHEDULES
rule that only applies to toolkit/components/extensions/test/browser/**
for instance. Though for this bug I'm just going to make it apply to browser/**
(turns out mobile/**
already has a rule).
Wrote the patch, just haven't had a chance to test it yet.
Assignee | ||
Comment 3•4 years ago
|
||
This rule states that if a push only modifies files under the /browser directory, then
we'll only schedule tasks that:
A) Use the 'skip-unless-schedules' optimization (this includes most builds and tests)
B) Are tagged with at one of the 'linux', 'macosx' or 'windows' components
This should be everything except Android builds and tests.
Assignee | ||
Comment 4•4 years ago
|
||
Gijs, you can copy my patch if you want to apply this rule to other dirs / files that can only affect desktop. There are probably a ton of places we can get little SCHEDULES wins like this, but it needs developers with the right context to know where these wins are.
I'll also add not to worry too much about making sure the rules are 100% accurate. We'll still run every task on every 10th autoland push. So the worst case scenario is that we optimize a task away, and then the sheriffs find the regression a few pushes later than they would have otherwise. There's no (additional) risk of missed regressions making it to central.
Assignee | ||
Comment 5•4 years ago
|
||
Also makes sure that 'mochitest-devtools-chrome' tasks are triggered by the
'mochitest-browser-chrome' component since they use the same manifest / test
formats.
Depends on D78906
Comment 7•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ab90ca4bf742
https://hg.mozilla.org/mozilla-central/rev/50bc520a5d0c
Assignee | ||
Updated•4 years ago
|
Description
•