Closed
Bug 1643822
Opened 4 years ago
Closed 4 years ago
getTextAtLine should not use split
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox79 fixed)
RESOLVED
FIXED
Firefox 79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
What were you doing?
getTextAtLine spends 40ms splitting text, that should be optimized. It ends up costing us 40ms X the number of breakpoints.
We can use a faster operation and do a better job of optimizing.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → jlaster
Status: NEW → ASSIGNED
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/225ed163bd8d
getTextAtLine should not use split. r=davidwalsh
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
|
||
Comment 4•4 years ago
|
||
Jason, thanks for giving an idea of the impact (slow long files with more breakpoints). Could you summarize the improvement and which cases (stepping, file loading, etc)?
Flags: needinfo?(jlaster)
|
||
Updated•3 years ago
|
Flags: needinfo?(jlaster)
You need to log in
before you can comment on or make changes to this bug.
Description
•