Closed
Bug 1644265
Opened 4 years ago
Closed 4 years ago
Ensure we don't interrupt DataStorage write with fast shutdown
Categories
(Core :: Security: PSM, enhancement, P2)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: dthayer, Assigned: dthayer)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1610136 looks at avoiding the need to write during shutdown for DataStorage, which would be a performance improvement. This bug just seeks to ensure correctness by guaranteeing that fast shutdown won't interrupt or skip a DataStorage write.
We should be able to check if DataStorage needs to write and flush it explicitly, avoiding the need to just spin event loops on threads until it gets to it.
|
Assignee | |
Comment 1•4 years ago
|
||
We want to ensure that DataStorage writes are not lost in a fast shutdown via
_exit(0). This ensures that any writes which have been queued via
DataStorage::AsyncWriteData are flushed prior to the _exit(0) call.
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Attachment #9155449 -
Attachment is obsolete: true
Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/677226ac9268
Reject new DataStorages if we are shutting down r=keeler
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in
before you can comment on or make changes to this bug.
Description
•